-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement] Add a new data source to automate retrieving images from a image-list file of a GitHub release #543
Comments
…automate retrieving images from a image-list file of a GitHub release rancher#543 Signed-off-by: Phan Le <phan.le@suse.com>
PR created #544 |
…tomate retrieving images from a image-list file of a GitHub release rancher#543 Signed-off-by: Phan Le <phan.le@suse.com>
…tomate retrieving images from a image-list file of a GitHub release rancher#543 Signed-off-by: Phan Le <phan.le@suse.com>
…tomate retrieving images from a image-list file of a GitHub release #543 Signed-off-by: Phan Le <phan.le@suse.com>
This repository uses an automated workflow to automatically label issues which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community issues better. If the issue is still relevant, please add a comment to the issue so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the issue in 14 days. Thank you for your contributions. |
Current issue:
Longhorn would like to automate adding/mirroring images. However, the currently available list of data sources don't fit the use-case of Longhorn:
github-releases
data source: This one finds new GitHub release tag and adds the images defined in theimages
field in theconfig.json
file. For example:config.json
file instructs the script to find GitHub release tags in the repokubernetes/cloud-provider-vsphere
. Then only add thegcr.io/cloud-provider-vsphere/cpi/release/manager
image with the found tags to the images-list. This doesn't fit the use-case of Longhorn because the list of Longhorn images are not fixed. We added/removed images between the releases. Therefore, it would require manual works to modify the"images"
fied of theconfig.json
oftenlygithub-latest-release
data source: this data source has same limitation as thegithub-releases
. Additionaly, Longhorn maintain multiple minor releases so a smaller version (e.g.,v1.4.5
) might be released after the current latest version (e.g.,v1.5.3
). This data source will not sync and add the smaller version (e.g.,v1.4.5
)registry
data source: Longhorn doesn't maintain a registry. Not applicablehelm-latest
,helm-oci
, andhelm-directory
data sources. With these data sources, the workflow attempts to runhelm template
and extract the images from the workload (deployment/daemonset/pod) output ofhelm template
. This approach doesn't work for Longhorn because not all Longhorn images appears in the output ofHelm template
(the images of Longhorn system managed components)Proposal
Add a new data source to automate retrieving images from a image-list file of a GitHub release,
github-releases-images-file
. This will look up GitHub releases, excluding pre-releases, and find the list of images inside a specified file of the release. This can be used if your project maintains a list of images in a file, e.g., https://github.com/longhorn/longhorn/blob/master/deploy/longhorn-images.txtAn example of configuration for
github-releases-images-file
could be:With the new
github-releases-images-file
data source, the aboveconfig.json
instruct the workflow to:longhorn/longhorn
, excluding pre-releasesdeploy/longhorn-images.txt
and add the newly found images to the images-list.The text was updated successfully, but these errors were encountered: