Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] fix isolated test failure in test_cache_hit_miss #626

Open
grlee77 opened this issue Nov 6, 2023 · 2 comments
Open

[BUG] fix isolated test failure in test_cache_hit_miss #626

grlee77 opened this issue Nov 6, 2023 · 2 comments
Assignees
@gigony
Labels
bug Something isn't working
Milestone
v24.12.00

Comments

@grlee77
Copy link
Contributor

grlee77 commented Nov 6, 2023 •
edited
Loading

Describe the bug

When working on wheel builds in #619, it was observed that a single test case, test_cache_hit_miss would fail when running the wheel tests. Temporarily, this test case is not being run because imagecodecs is not installed as part of the test dependencies during wheel testing. Before release 23.12.00 we should enable install of imagecodecs and openslide-python again so that all cucim.clara submodule test cases get run.
@grlee77 grlee77 added the bug Something isn't working label Nov 6, 2023
@grlee77 grlee77 added this to the v23.12.00 milestone Nov 6, 2023
@grlee77 grlee77 mentioned this issue Nov 6, 2023
Merged
@gigony gigony self-assigned this Nov 14, 2023
@grlee77
Copy link
Contributor Author

grlee77 commented Nov 17, 2023

#634 re-enables these additional test dependencies and can be used as a basis to start from when fixing this issue

@grlee77 grlee77 mentioned this issue Nov 17, 2023
Merged
@jakirkham jakirkham modified the milestones: v23.12.00, v24.02.00 Dec 1, 2023
@jakirkham
Copy link
Member

Moving to 24.02 as we are already in code freeze for 23.12

rapids-bot bot pushed a commit that referenced this issue Dec 4, 2023
@grlee77
install imagecodecs and openslide-python dependencies so additional t…
69c0099 
…ests will run (#634)

This MR may initially fail during wheel testing due to #626, as a few test cases relying on these packages were not being run at the time #619 was merged.

Authors:
  - Gregory Lee (https://github.com/grlee77)
  - https://github.com/jakirkham

Approvers:
  - Ray Douglass (https://github.com/raydouglass)
  - Gigon Bae (https://github.com/gigony)
  - https://github.com/jakirkham

URL: #634
@jakirkham jakirkham modified the milestones: v24.02.00, v24.06 Apr 16, 2024
@jakirkham jakirkham modified the milestones: v24.06.00, v24.08.00 Jun 25, 2024
@jakirkham jakirkham modified the milestones: v24.08.00, v24.12.00 Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gigony gigony

Labels
bug Something isn't working
Projects
cucim
Status: Todo
Milestone
v24.12.00
Development

No branches or pull requests
3 participants
@gigony @jakirkham @grlee77