Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build args in dockerfiles should not use realistic values #100

Closed
jameslamb opened this issue Aug 29, 2024 · 0 comments · Fixed by #101
Closed

Build args in dockerfiles should not use realistic values #100

jameslamb opened this issue Aug 29, 2024 · 0 comments · Fixed by #101

Comments

@jameslamb
Copy link
Member

Description

Dockerfiles in this repo currently set realistic values as defaults for build arguments

ARG CUDA_VER=11.8.0
ARG LINUX_VER=ubuntu20.04
ARG PYTHON_VER=3.10

But never intentionally use those defaults... it's always expected that those build arguments will be fulfilled by values passed through to docker build:

echo "docker build --pull -t ${BUILD_IMAGE}:${BUILD_TAG} ${BUILD_ARGS} ${BUILD_DIR}"

Those realistic values should be replaced with the literal string unset or similar.

Benefits of this work

Reduces the risk of silently building and tagging an image that's using the wrong configuration (because of mistakes in passing through build args).

Acceptance Criteria

  • all configuration for build arguments is driver from outside of Dockerfiles

Approach

This: rapidsai/docker#689 (comment)

Notes

Created this issue based on #97 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant