From 8726f87bee97f1eff8cc6c374ebdf70d1b63b12c Mon Sep 17 00:00:00 2001
From: "Mads R. B. Kristensen" <madsbk@gmail.com>
Date: Tue, 1 Oct 2024 09:32:06 +0200
Subject: [PATCH] fix virtual dtor

---
 cpp/include/kvikio/remote_handle.hpp       | 3 ++-
 python/kvikio/kvikio/benchmarks/http_io.py | 4 ++--
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/cpp/include/kvikio/remote_handle.hpp b/cpp/include/kvikio/remote_handle.hpp
index 1836c5bade..8bdd75dfc3 100644
--- a/cpp/include/kvikio/remote_handle.hpp
+++ b/cpp/include/kvikio/remote_handle.hpp
@@ -333,6 +333,8 @@ class RemoteEndpoint {
    * @returns A string description.
    */
   virtual std::string str() = 0;
+
+  virtual ~RemoteEndpoint() = default;
 };
 
 /**
@@ -343,7 +345,6 @@ class HttpEndpoint : public RemoteEndpoint {
   std::string _url;
 
  public:
-  HttpEndpoint() = default;
   HttpEndpoint(std::string url) : _url{std::move(url)} {}
   void setopt(detail::CurlHandle& curl) override { curl.setopt(CURLOPT_URL, _url.c_str()); }
   std::string str() override { return _url; }
diff --git a/python/kvikio/kvikio/benchmarks/http_io.py b/python/kvikio/kvikio/benchmarks/http_io.py
index 1234c28304..9a24503a7f 100644
--- a/python/kvikio/kvikio/benchmarks/http_io.py
+++ b/python/kvikio/kvikio/benchmarks/http_io.py
@@ -38,8 +38,8 @@ def run() -> float:
 
 
 API = {
-    "cupy-kvikio": partial(run_numpy_like, xp=cupy),
-    "numpy-kvikio": partial(run_numpy_like, xp=numpy),
+    "cupy": partial(run_numpy_like, xp=cupy),
+    "numpy": partial(run_numpy_like, xp=numpy),
 }