Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artifacts when using Keyboard or Column #313

Open
rebzden-baracoda opened this issue Jul 31, 2023 · 2 comments
Open

Artifacts when using Keyboard or Column #313

rebzden-baracoda opened this issue Jul 31, 2023 · 2 comments

Comments

@rebzden-baracoda
Copy link

Hello,
Once again thank you for this library, it's really much better than writing everything by hand. I have a question because I have two issues with the Keyboard and one with Column.

  1. The Keyboard component is missing the Backspace icon, how to add it (is it a dependency or some svg in static folder?), or customise it? Could you also make a bit more clear as for the formats and layouts go in the documentation? It's not as clear really, the example has only one layout so it's not showing how to change items. Also the new typings (in v2.7.0) are not aligned with the documentation.
  2. The Keyboard flickers when switching the layout, it seems like it's trying to animate the drawing of the layout, can it be disabled somehow? It also happens on the storybook, it makes it seem a bit less polished than it could.
  3. The Column rows the same as the keyboard, makes a bit of the artefact, when drawing many rows at the same time - it's more visible on slower equipment. This is how it looks like:
    Screenshot 2023-07-31 at 10 10 18
    Screenshot 2023-07-31 at 10 10 31
    Is there any way to mitigate this issue?

Thank you for the library and any help with resolving those issues :)
Kacper

@rebzden-baracoda
Copy link
Author

I've found the reason for it! It was forceZIndexContext on the column, so the only thing left is the keyboard flickering issue, is there anything that I can do about it?

@erautenberg
Copy link
Contributor

Hi @rebzden-baracoda, so sorry for the delay on this! We do have a ticket on our backlog to work on optimizing the Keyboard and not re-instantiate is as you flip between layouts, but have not been able to prioritize it just yet due to some internal projects. If you are able to dig in to try to solve the flickering issue, or even provide more details on exactly what you're seeing, how you are able to make it worse or mitigate it, reproduction steps, etc., that would all be appreciated and we would welcome any contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants