Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move LocalAssetStorage and LocalAssetProvider classes to TundraCore #774

Open
Stinkfist0 opened this issue Aug 31, 2014 · 3 comments
Open

Move LocalAssetStorage and LocalAssetProvider classes to TundraCore #774

Stinkfist0 opened this issue Aug 31, 2014 · 3 comments
Labels
Refactoring/Redesign

Comments

@Stinkfist0
Copy link
Contributor

Tundra is unusable without these classes. No need to have them in a runtime-loaded plug-in. After moving the files around, AssetModule could be renamed to HttpAssetProvider.
@jonnenauha
Copy link
Member

+1 and at the same time local:// should be made a strict relative path instaed of "a file name that gets recursively searched from all known local storages".

We had a discussion about this with @cadaver and he seemed to agree. This would be a good place to do that change.

@jonnenauha
Copy link
Member

So src/Core/TundraCore/Asset would probably be the logical place? I recon there is no need to make TundraCore/LocalAssetProvider

@Stinkfist0
Copy link
Contributor Author

Yupyup.

Stinkfist0 added a commit to Adminotech/tundra that referenced this issue Oct 14, 2014
@Stinkfist0
Move LocalAssetProvider from AssetModule to TundraCore. Closes realXt…
60dbb9b 
…end#774.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Refactoring/Redesign
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonnenauha @Stinkfist0