Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup interactive testing for windows #5573

Closed
anandrkskd opened this issue Mar 21, 2022 · 1 comment · Fixed by #6091
Closed

Setup interactive testing for windows #5573

anandrkskd opened this issue Mar 21, 2022 · 1 comment · Fixed by #6091
Assignees
@feloy
Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering

Comments

@anandrkskd
Copy link
Contributor

/area testing

Which functionality do you think we should add?

Currently, we don't have a working interactive testing framework on Windows. We need to enable the interactive testing for windows to increase the coverage of our tests.
@openshift-ci openshift-ci bot added the area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering label Mar 21, 2022
@anandrkskd anandrkskd self-assigned this Mar 21, 2022
@anandrkskd
Copy link
Contributor Author

We are using github.com/kr/pty to create a pseudo tty to test the interactive mod, as github.com/kr/pty doesn't support creation of pseudo Windows tty, the more actively maintained forked lib github.com/creack/pty also doesn't support windows pty, there is PR to make support for it using ConPty. We can also try to use the ConPty directly for the test to create pty.

@rm3l rm3l mentioned this issue Jun 27, 2022
Closed
3 tasks
@rm3l rm3l added the status/blocked Denotes an issue or PR that is blocked on something (e.g., issue/PR in different repo) label Jun 30, 2022
@feloy feloy mentioned this issue Sep 5, 2022
Merged
3 tasks
@feloy feloy assigned feloy and unassigned anandrkskd Sep 5, 2022
@feloy feloy removed the status/blocked Denotes an issue or PR that is blocked on something (e.g., issue/PR in different repo) label Sep 5, 2022
@rm3l rm3l added the v3 label Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@feloy feloy

Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering
Projects
No open projects
odo v3.0.0
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix interactive tests on Windows feloy/odo
3 participants
@rm3l @feloy @anandrkskd