Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's work all together on an other fork ? #340

Open
Yukams opened this issue Jun 20, 2022 · 9 comments
Open

Let's work all together on an other fork ? #340

Yukams opened this issue Jun 20, 2022 · 9 comments

Comments

@Yukams
Copy link

Yukams commented Jun 20, 2022

Hi dear community,

I've been working with (or against) this repository for 2 months now. I worked on fixing it on my branch and succeeded to make it work in Android as expected (phone reboot, app killed, re-opening the app, support for Flutter 3.0, callback working properly) thanks to some of the pull requests open here.

Though, I still see that a lot of new people come across this repo and find themselves stuck with the same problems I've faced.

Let's be real, rekabhq, the owner of this library, will never update it again. We need to move onto someone else's fork.
I personally can't figure out how to fix it for iOS, though I desperately need it.

As I'm a young developer, I'm pretty sure someone with open source experience would be better than me to maintain this project. If any of you feels like it, you can fork my fork of the library and we could try to all move to this new repo.
Else we'll be stuck forever here and new people will keep losing their time on a broken lib.

Note : my fork is quite a mess when it comes to all the lasts commits, but hey, it works at least.

EDIT : We now have it on pub.dev ! https://pub.dev/packages/background_locator_2

@lasd14
Copy link

lasd14 commented Jun 24, 2022

Hi @Yukams I think that is a good idea what you propose, after all thats the objetive of open source.

PD: I was looking at your package and I see that you solved the reboot issue, my only question is that I test trying to save the location updates in a database at the time of reboot and this is not doing it, would you know why? (That is, when you start the service and once you restart the cell phone, do you continue to receive updates?)

@Yukams
Copy link
Author

Yukams commented Jun 27, 2022

Hello @lasd14, I just tried it on my project and yes it's still working for me on Android after a phone reboot ! Just saying you have to restart the location simulation on your Android emulator after a phone reboot :)

Though, you can from now on publish issues and improvements directly on my fork :)

@daviddagan
Copy link

Can you upload your git as a new project and plugin in pub dev?
we all be thankful to you

@Yukams
Copy link
Author

Yukams commented Jul 8, 2022

Hi @daviddagan, I'll see what I can do !

@daviddagan
Copy link

hey I'm trying to use your fork and you forced the plugin to use min SDK version 21
it was necessary?.

@Yukams
Copy link
Author

Yukams commented Jul 10, 2022

Hi @daviddagan, so I had a quick look and it seems like the lib would work with lower minSDK version (I tried with 19). I'm pretty sure I had a good reason to set it higher but couldn't find it today, maybe I don't have to anymore. I'll have a deeper look tomorrow, what minSDK do you need ?
Also, feel free to open an issue directly on my fork's github page, as it may be better for tracking the evolution of said fork

@daviddagan
Copy link

Hi @Yukams, the Min Sdk before has been 19.
and sure, next time it will be on your forked git :)

@Yukams
Copy link
Author

Yukams commented Jul 11, 2022

Hi @daviddagan, I've pushed a branch for a minsdk of 19, you can use it by putting this in your pubspec.yaml under dependancies

background_locator:
  git:
    url: https://github.com/Yukams/background_locator_fixed
    branch: minsdk_29

I'm looking right now to publish my fork on pub.dev too, I will update you on that

@Yukams
Copy link
Author

Yukams commented Jul 11, 2022

EDIT : the fork is already up to date, ignore my previous message.

So I added the package to pub.dev https://pub.dev/packages/background_locator_2
Now you should be able to use it by adding this to your pubspec.yaml :

background_locator_2: ^2.0.3

Also you'll need to replace all your imports from background_locator to background_locator_2
All the rest should work the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants