Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rehype-raw 7.0.0 seems not supported #769

Closed
4 tasks done
erwan-joly opened this issue Sep 11, 2023 · 4 comments
Closed
4 tasks done

rehype-raw 7.0.0 seems not supported #769

erwan-joly opened this issue Sep 11, 2023 · 4 comments
Labels
👯 no/duplicate Déjà vu 👎 phase/no Post cannot or will not be acted on

Comments

@erwan-joly
Copy link

erwan-joly commented Sep 11, 2023

Initial checklist

Affected packages and versions

8.0.7

Link to runnable example

No response

Steps to reproduce


With 7.0.0 the readme does not work anymore

import React from 'react'
import ReactDom from 'react-dom'
import ReactMarkdown from 'react-markdown'
import rehypeRaw from 'rehype-raw'

const input = `<div class="note">

Some *emphasis* and <strong>strong</strong>!

</div>`

ReactDom.render(
  <ReactMarkdown rehypePlugins={[rehypeRaw]} children={input} />,
  document.body
)

Expected behavior

no error

Actual behavior

we get this error TS2322 (TS) Type '(options?: Options) => (tree: Root, file: VFile) => Root' is not assignable to type 'Pluggable<any[]>'

Runtime

No response

Package manager

No response

OS

No response

Build and bundle tools

No response

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Sep 11, 2023
@github-actions
Copy link

Hi! Thanks for taking the time to contribute!

Because we treat issues as our backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn’t an exact duplicate but is closely related.

Thanks,
— bb

@ChristianMurphy
Copy link
Member

Duplicate of #763

@ChristianMurphy ChristianMurphy marked this as a duplicate of #763 Sep 11, 2023
@ChristianMurphy ChristianMurphy closed this as not planned Won't fix, can't repro, duplicate, stale Sep 11, 2023
@github-actions

This comment has been minimized.

@github-actions github-actions bot added 👎 phase/no Post cannot or will not be acted on and removed 🤞 phase/open Post is being triaged manually labels Sep 11, 2023
@ChristianMurphy
Copy link
Member

The updates are making their way through several hundred packages, for now pin the previous major until the new react-markdown major is released

tatumroaquin added a commit to tatumroaquin/mern-blog that referenced this issue Sep 19, 2023
- pin rehype-raw to v6.1.1 while waiting for type updates remarkjs/react-markdown#769
- pin remark-mermaidjs to v4.1.1 according to a similar issue remcohaszing/rehype-mermaid#1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👯 no/duplicate Déjà vu 👎 phase/no Post cannot or will not be acted on
Development

No branches or pull requests

2 participants