Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash is removed if it contains an =. #1180

Open
kevincox opened this issue Apr 11, 2020 · 0 comments
Open

Hash is removed if it contains an =. #1180

kevincox opened this issue Apr 11, 2020 · 0 comments

Comments

@kevincox
Copy link
Contributor

Right now if the hash contains an = it is assumed to "belong" to the remotestorage.js oauth flow and is removed in its entirely. This is very annoying for websites that want to use the hash themselves. Instead the hash should only be removed if there is strong evidence to indicate that we are doing the remotestorage.js oauth flow (for example rsDiscovery or access_token and state are set). Ideally even stronger verification could be done such as embedding a random value that is unlikey to be used by the embedding application.

var params = extractParams(),
location;
if (params) {
location = Authorize.getLocation();
location.hash = '';
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant