You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
the Google Drive backend retrieves a file ID but doesn't check that that file ID exists before using it in a request, leading to (if the requested file doesn't exist at all in Google Drive and so has no ID) requests being made to https://www.googleapis.com/drive/v2/files/undefined which is definitely wrong.
This isn't a PR because I'm not sure what should happen here; should that function throw an error, or fake a response object with statusCode 404, or something else?
The text was updated successfully, but these errors were encountered:
This isn't a PR because I'm not sure what should happen here; should that function throw an error, or fake a response object with statusCode 404, or something else?
Faking a 404 seems like a reasonable option to me. I guess any potential issues with that approach would become apparent once you implement and test it.
In _getFile at
remotestorage.js/src/googledrive.ts
Line 476 in 5b580e8
remotestorage.js/src/googledrive.ts
Line 477 in 5b580e8
https://www.googleapis.com/drive/v2/files/undefined
which is definitely wrong.This isn't a PR because I'm not sure what should happen here; should that function throw an error, or fake a response object with statusCode 404, or something else?
The text was updated successfully, but these errors were encountered: