-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct docs about permissions for Dropbox backend (and why not Google Drive?) #1312
Comments
It's not the lack of a permissions model that's the problem, it's that Dropbox (and Google Drive) have permission models that conflict with the RS permissions model. An RS scope can be accessed by more than one app (for example, the |
Yes, that's correct. You can either grant the app permission to write its own files, or you can have interoperable apps that access the same data. See this current Webmarks issue for some more discussion and info regarding Google Drive. There's a scope where you can write to It may make sense to switch rs.js to app folders entirely by default, and tell users that single-app access is the drawback compared to RS, especially for new apps where data migration to a different folder is not necessary. |
Yeah! I just want Drive and Dropbox support so (a) users can try my feature without having to make a new account (with a company they haven't heard of), and (b) as a backup sync method. Both of those backends were slower than RS via 5apps --and I was intending on telling users that-- but they worked well enough for a try or for a backup method. @DougReeder got you. Sharing data doesn't make sense for my application (which is adding a device sync feature to a web app that was designed only for local storage), for a few reasons, most importantly because nobody else would use it. There is probably some well-organized effort to make an interoperable data format for LLMs that I don't know about. Making an RS data module would make sense for them. Back to my main suggestion. I probably told Dropbox that I want a "Scoped App (App Folder)" when I set it up. Looks like this in the main dropbox app settings page: Screenshot from 2024-04-06 15-52-01 I can't say the same for Google Drive. I tried patching remotestorage.js and fiddling with the google dev console settings for a couple hours, but couldn't get the consent screen to change. |
With Google Drive, you'd have to change the scope to |
Currently reads:
This is not accurate for Dropbox. Users of my app see an API Request Authorization page from dropbox.com that says:
That RS docs excerpt does seem to be accurate currently for the Google Drive backend, surprisingly. But is that necessary? Could've sworn I've granted some app's Google Drive integration access to just its "app data folder" before, i.e. this https://developers.google.com/drive/api/guides/appdata. More specifically, why can't we just replace this line:
remotestorage.js/src/googledrive.ts
Line 17 in 1e0cccc
with
https://www.googleapis.com/auth/drive.appdata
? It's described as "View and manage the app's own configuration data in your Google Drive." There is also adrive.appfolder
scope code (see here); not sure if that's just an alias or what.The text was updated successfully, but these errors were encountered: