Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wireclient.ts and googledrive.ts don't honor Retry-After header in 429 and 503 responses #1315

Open
DougReeder opened this issue Jul 18, 2024 · 2 comments
Labels

Comments

@DougReeder
Copy link
Contributor

I have experimentally determined that the wireclient does not pause when it receives a 429 Too Many Requests response with a Retry-After header. As wireclient.ts does not contain any references to 429, 503 or the retryAfterMs function in requests.ts, this appears to be an oversight in the code.

As googledrive.ts likewise contains no references to 429, 503 or the retryAfterMs function in requests.ts, but dropbox.ts does contain references to 429, 503 and the retryAfterMs function in requests.ts, presumably googledrive.ts shares this oversight, but dropbox.ts does not.

@raucao
Copy link
Member

raucao commented Jul 18, 2024

It's not an oversight, but there was simply never an RS server implementation that necessitated throttling for authorized requests. The logical explanation is that the function only exists for the Dropbox back-end.

@raucao raucao added the feature label Jul 18, 2024
@DougReeder
Copy link
Contributor Author

Well, there is a native RS implementation that sends 429s now!
remotestorage/armadietto@00f3efd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants