Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty outline when opening folder #151

Open
PatrickMassot opened this issue Jun 30, 2022 · 14 comments
Open

Empty outline when opening folder #151

PatrickMassot opened this issue Jun 30, 2022 · 14 comments
Labels
backlog Something that is not a priority and will be addressed in a future release bug Something isn't working

Comments

@PatrickMassot
Copy link

When opening a game folder and editing a script file from there, nothing shows up in the outline. If I open a single script.rpy then I see the outline. This is a bit confusing for me since I'm rather used to VScode extensions that won't do anything until you open a project folder.

Compare:
image
where the outline works but the file explorer doesn't show other files and
image
where the outline is empty but I can see all files in the file explorer.

This is on a fresh install of RenPy 8.0.0 with VSCode extension version 2.0.11. I may be missing something obvious, I installed RenPy for the first time yesterday. In particular I don't know whether this should be considered an actual bug or a documentation issue or a stupid newbie user issue.

@Savage1969
Copy link

Savage1969 commented Jul 1, 2022

FWIW: It works on my end. Note that I've noticed that certain symbols such as labels require them to be formatted with proper indentation rules. In other words if you indent labels they will not show up in the outline, they must be outdented flush to show in the outline, etc.

@LuqueDaniel
Copy link
Member

I've tested it and can't reproduce it.

@Savage1969
Copy link

Savage1969 commented Jul 1, 2022

It works in most projects I've tested so far (over 2 dozen). The classes branch is extremely useful btw. It can be temperamental and I'm trying to isolate where the issue is when it fails to work, but the majority of the time it does on my end.

For example, all the below are expandable in this file example:
image

@duckdoom4
Copy link
Collaborator

duckdoom4 commented Jul 6, 2022

Possibly an issue with missing navigation data?

Do you have this with all projects or just with "The Question"

I'll look into this when I have more time.

@duckdoom4
Copy link
Collaborator

FWIW: It works on my end. Note that I've noticed that certain symbols such as labels require them to be formatted with proper indentation rules. In other words if you indent labels they will not show up in the outline, they must be outdented flush to show in the outline, etc.

This should be fixed as soon as the new syntax branch gets merged. We still need to do more testing on that branch before making it fully public though.

@duckdoom4
Copy link
Collaborator

Please check if this has been fixed as of v2.1.0-pre-release

@duckdoom4 duckdoom4 added the help wanted Extra attention is needed label Jul 11, 2022
@Savage1969
Copy link

Savage1969 commented Jul 17, 2022

Please check if this has been fixed as of v2.1.0-pre-release

Nope, it was mostly fine before, now many project get this never-ending initialization in the bottom-left corner with no outline population:
image

@duckdoom4
Copy link
Collaborator

Please check if this has been fixed as of v2.1.0-pre-release

Nope, it was mostly fine before, now many project get this never-ending initialization in the bottom-left corner with no outline population: image

Good to know, thanks for the update. I'll look into it when I find the time :)

@duckdoom4 duckdoom4 added bug Something isn't working and removed help wanted Extra attention is needed cannot reproduce labels Jul 18, 2022
@Savage1969
Copy link

FYI: To make it easier to replicate the "never-ending initialization" simply navigate to any RenPy project's "renpy/common" folder, open that "common" folder in VSC, choose any RPY file. This will negate the use of personal files in the replication process.

@multimokia
Copy link
Contributor

I think this is an issue in the extension seemingly requiring renpy navigation data. I think it may be a good idea to remove this dependency on an external sdk/application as not all git projects are the same, nor will they contain the renpy binaries or compilation info (nor should they, in my opinion)

@duckdoom4
Copy link
Collaborator

duckdoom4 commented Aug 2, 2022

This navigation data should be in any project that has executed at least once. It's a file generated by the renpy launcher.

Tho to be honest, I think I will remove it at some point since we won't need it as soon as we have the variable/data storage that will be generated using the tokenizer

@multimokia
Copy link
Contributor

multimokia commented Aug 4, 2022

I don't use the renpy launcher for my projects as the projects I work on are mods or extension libraries of sorts, rather than fully-fledged games. So all the code is compiled when you actually drop it into an existing game. Glad to hear this won't be an issue with the tokenizer though

@duckdoom4 duckdoom4 added the backlog Something that is not a priority and will be addressed in a future release label Jan 29, 2023
@FaceCrap
Copy link

Well now, and here I was wondering why my outline stays empty. Like the last poster, I don't run VSC from the SDK but rather open the game folders directly.
I read above a mention it worked if opening a single RenPy file directly, however, my outline has never populated. Neither with opening a game's folder nor opening a single file.

@LuqueDaniel
Copy link
Member

@FaceCrap Currently, the extension uses the saves/navigation.json file for several features. You have to run the project using the Ren'Py launcher to generate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Something that is not a priority and will be addressed in a future release bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants