-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: Generate a warning for unmatched {color=#......} tags #255
Comments
That's a great idea, this should be added. It should also check for other string tags that are not properly closed. |
I think this is supported |
Hmm, that changes things. That makes for a slightly complex regex. I'll see what I can do |
Making markup tags survive until the end of the string might not be the only thing. there's also the possibility that the same markup tag can occur more than once in the same string. Frankly, I could care less how it's solved, whether by terminating markup at the end of a string (which can span multiple lines too it seems) or by actually forcing to use the closing tag. |
Can you post a screenshot of what you're currently seeing? Additional markup tags should overwrite the previous tags if any overlap. So if another color tag is opened, it should already change the color to a new tag. |
the color does indeed change when a new color tag is encountered ;) That is why I compared the result to a my-little-pony toilet :D Because the color keeps continuining until another color tag is encountered, causing the file to have big chunks of differently colored code/dialoge |
I've tasked myself to clean up code for existing projects, and sometimes I get files that don't properly close {color=#....} tags. Although Ren'Py projects themselves don't seem to be affected negatively, in vscode it is often causing the code either to be displayed in the defined color from that point or syntax highlighting getting completely disabled.
It would be nice if this would generate a warning, so I can easily jump to the position(s) where this happens.
The text was updated successfully, but these errors were encountered: