Possibility of Regression Bug

[Tejas2805]

The Travis build which hadn't been failing upto 3 days ago, has started failing. This is when we started merging all the PRs again. We might have a regression bug. Let's look into this and find out the reason.

Can check the travis build here.

This is related to individual project dashboard for CS2103T

[Tejas2805]

Could have been due to #1050 or #1192 . Other PRs seem unlikely as build fails while analyzing commits.

[Tejas2805]

@ang-zeyu @jamessspanggg Could you guys take a look into this.

[jamessspanggg]

On first glance, it is due to the student having a file name called ..\data\duke.txt, which leads to the file not being matched in the isFileGlobMatching method. Don't think it's due to any of our recent PRs merged as we did not touch the functionality of the file matching. Student's repo

Will investigate further.

[jamessspanggg]

@Tejas2805 can you inform the prof to temporarily fix the issue by adding ..\data\duke.txt in the Ignore Glob List column of https://github.com/EdmondOng/duke.git in author-config.csv?

[damithc]

@Tejas2805 can you inform the prof to temporarily fix the issue by adding ..\data\duke.txt in the Ignore Glob List column of https://github.com/EdmondOng/duke.git in author-config.csv?

Which repo? Can do a PR?

[jamessspanggg]

Which repo? Can do a PR?

Created a PR here: nus-cs2103-AY1920S2/ip-dashboard#1

[damithc]

Actually, that will update that semester's dashboard which is supposed to frozen in time at the end of that semester. At lease we should also add an end-date the CLI parameters to prevent it analyzing repos until today. Also, the PR fails the build.

[Tejas2805]

I thought it could be due to the same file too, but the thing is the file has been there from before. Therefore, that shouldn't have been the cause of the build to fail.

[Tejas2805]

Also, the PR fails the build.

The build hasn't failed due to the initial reason. But the same error at a different repo.

[jamessspanggg]

The problem is due to git specifically prints out filename surrounded by double quotes, if the filename contains any special characters (in this bug's case, it is due to the special character ""). I have tested the behaviour, and an example is shown below:

Will issue a fix soon.

[Tejas2805]

Ah I see. Is it some new update though? As initially it wasn't failing.

[jamessspanggg]

Ah I see. Is it some new update though? As initially it wasn't failing.

I'm not so sure, I tried checking out to the version of the last successful Travis build (commit 0f57aab) and ran the same build, and there were still errors.

The problem is due to git specifically prints out filename surrounded by double quotes

Still need some time to figure out the bugs, as the one described above is not the only issue. Would appreciate it if we can investigate together.

[jamessspanggg]

Update: the bug is due to #1192 not handling files with names that are automatically escaped and double quoted by GitHub. For e.g. file name ..\data\duke.txt -> "..\\data\\duke.txt".

Upon investigating further, the code in FileInfoExtractor#getEditedFileInfos also made the same mistake of not handling this case, but not reflected in the bug as they simply skip the processing of these files when not matched with their regex.