Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: remove LocalKeyvault and refactor SignerStore and it's implementations as a service #465

Open
1 task done
MVrachev opened this issue Mar 8, 2024 · 3 comments
Open
1 task done
Assignees
Milestone

Comments

@MVrachev
Copy link
Member

MVrachev commented Mar 8, 2024

What is the task about?

After a discussion with @kairoaraujo we agreed when we remove LocalKeyvault implementation and move the SignerStore implementation under repository_service_tuf_worker/services/keyvault to be consistent with storage services.

We can also rename SignerStore to KeyVault as it's still a keyvault service.

We plan to add this change for RSTUF Worker at 1.0.0.

Parent feature

No response

References

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@MVrachev MVrachev added this to the v1.0.0 milestone Mar 8, 2024
@lukpueh
Copy link
Collaborator

lukpueh commented May 3, 2024

@MVrachev, may I ask what "refactor SignerStore" means?

@lukpueh
Copy link
Collaborator

lukpueh commented May 3, 2024

FYI: #507 removes LocalKeyVault.

@MVrachev
Copy link
Member Author

MVrachev commented May 7, 2024

@MVrachev, may I ask what "refactor SignerStore" means?

The phrasing is not correct. I don't remember what refactoring did I mean, but only the move of SignerStore to repository_service_tuf_worker/services/keyvault as a replacement of LocalKeyvault.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

3 participants