Skip to content
This repository has been archived by the owner on Jun 15, 2020. It is now read-only.

Prettier pre-commit hook #11

Open
oferitz opened this issue May 23, 2018 · 8 comments
Open

Prettier pre-commit hook #11

oferitz opened this issue May 23, 2018 · 8 comments
Labels

Comments

@oferitz
Copy link
Contributor

oferitz commented May 23, 2018

Create pre-commit hook to automate Prettier integration.

https://prettier.io/docs/en/precommit.html

@atris
Copy link

atris commented May 23, 2018 via email

@thelinuxlich
Copy link

What do you think about StandardJS?

@oferitz
Copy link
Contributor Author

oferitz commented May 23, 2018

@thelinuxlich i like StandardJS. in terms of style i set Prettier in the spirit of StandardJS, we can definitely use them together Prettier for code style and Standard for linting. it might require some non-trivial tweaking, but it's due-able.

@thelinuxlich
Copy link

Nice, I will do the same with the rethinkdbdash codebase.

@sagivf
Copy link
Contributor

sagivf commented May 25, 2018

Not critical for me but I am +1 for StandardJS but -1 for Prettier.
I find StandardJS saves time and merge conflicts but prettier does the opposite. At least that's been my experience.

@rodrigooler
Copy link
Member

rodrigooler commented Aug 31, 2018

@oferitz @thelinuxlich @sagivf @atris I would like to start with this issue, to also go along with the project codebase.

It still keep the same logic of integrating prettier with standartjs?

@sagivf
Copy link
Contributor

sagivf commented Sep 3, 2018

@rodrigooler Go head! 🚀 🚀

@PierreAndreis
Copy link

should this issue be closed?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

6 participants