Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests failing #28

Open
NotJustAnna opened this issue Mar 5, 2020 · 2 comments
Open

Fix tests failing #28

NotJustAnna opened this issue Mar 5, 2020 · 2 comments
Labels
bug Something isn't working need help Requires attention from management python-scripts This issue requires messing with the python scripts...

Comments

@NotJustAnna
Copy link
Member

This issue tracks the failing generated tests.

MathLogicLogic

Appears to happen because of outdated polyglot tests? The error happens because Python.

r.expr(r.expr(True) & r.expr(False) == r.expr(False) | r.expr(True)) seems to be related to a Python-specific behaviour.

Gets translated just fine to r.expr(r.expr(true).and(r.expr(false)).eq(r.expr(false).or(r.expr(true)))) and the test fails because it compiles correctly.

MathLogicBit

Appears to happen because of outdated polyglot tests?

r.expr(-1).bit_sal(54) is evaluated and the result is written as a Double. Jackson will parse it as Double and it'll live as a Double.

A quick fix should be as easy as casting all numbers to double before asserting equality, because Python. I don't know if it's as good as it's easy, though.

Replacing 54 with 53 and recalculating the value should make the test pass.

MutationInsert

The error happens because Python.

'a'*500 is valid in python but invalid in Java.

Polyglot translates to r.mul("a", 500L), which is invalid to RethinkDB.

Fix needs to deal with python scripts, see #11

MetaGrant/ChangefeedsNow

Either badly generated, or polyglot tests are outdated.

ChangefeedsNow is so bad that the generated test was removed from git tree. (It blocks all tests for 2 minutes)

@NotJustAnna NotJustAnna added bug Something isn't working python-scripts This issue requires messing with the python scripts... need help Requires attention from management labels Mar 5, 2020
@NotJustAnna
Copy link
Member Author

Tests were deleted by #30, but can be generated by running genTestJava task. Starting now, PRs which break tests (or generates broken ones) won't be accepted.

@gabor-boros
Copy link
Member

@adriantodt What do you think about adding this info to the readme or somewhere and closing this issue? 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working need help Requires attention from management python-scripts This issue requires messing with the python scripts...
Projects
None yet
Development

No branches or pull requests

2 participants