Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValueChange Missing Field 'error' #45

Open
ChrisTalman opened this issue Jan 31, 2020 · 3 comments
Open

ValueChange Missing Field 'error' #45

ChrisTalman opened this issue Jan 31, 2020 · 3 comments

Comments

@ChrisTalman
Copy link

According to the insert() documentation:

Documents in changes for which an error occurs (such as a key conflict) will have a third field, error, with an explanation of the error.

It seems that ValueChange currently lacks this in the type definitions.

The fix would seem to be very minor: simply add to ValueChange a third optional property, error.

@ChrisTalman ChrisTalman changed the title ValueChange Missing Field 'Error' ValueChange Missing Field 'error' Jan 31, 2020
@ronzeidman
Copy link

I couldn't reproduce this error field. tried listening to a table that got a conflict error and I got nothing in the "changes" feed...

@ChrisTalman
Copy link
Author

ChrisTalman commented Jan 31, 2020

I encountered the field during my use of forEach().

To be clear, this is the changes field of an insert() result object.

@ronzeidman
Copy link

Found it, returnChanges should be "always" for me to see it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants