Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in examples.ipynb #1

Open
fomightez opened this issue Oct 11, 2024 · 0 comments
Open

Typo in examples.ipynb #1

fomightez opened this issue Oct 11, 2024 · 0 comments

Comments

@fomightez
Copy link

fomightez commented Oct 11, 2024

Under the section, it says:

"The SES and SAS are analyical."

At first, I thought it was just a typo of analytical? However, the next line says, "The volume is numerical. In the case of a single sphere, it is always too small, but converges with high density." So maybe not that simple?

You can see my current attempt near the bottom of this notebook in the 'binderized' branch of my fork of this repo. I may be way off on what was intended there for the bulleted items.


For context, I came across this testing out the notebook in sessions launched where the msms_wrapper script would already be present the examples notebook would work in the session.
You can try it out by going here and pressing the 'launch binder' badge.
All it really needed was adding the binder directory with the necessary packages listed in requirements.txt. And then editing the badge to point the MyBinder service at the right place. Adding in PyVista though required to take things to the pro-level and wasn't able to control it as much as I would have liked. For example, I couldn't find the right combination to install curl. (If you launch with that branch as the source, you can see before I added PyVista, the other things worked fine by clicking here to try it out. )

For now, I rearranged the notebook sections because the PyVista-featuring section wasn't working; however, I since fixed that I also wondered whether other more Jupyter-centric surface/volume rendering tech may be easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant