Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMP ACT #9

Open
2 of 13 tasks
jjscheel opened this issue Mar 16, 2023 · 29 comments
Open
2 of 13 tasks

PMP ACT #9

jjscheel opened this issue Mar 16, 2023 · 29 comments
Assignees

Comments

@jjscheel
Copy link
Contributor

jjscheel commented Mar 16, 2023

Technical Group

Privileged Spec IC

ratification-pkg

Priv 1.11

Technical Liaison

Greg Favor

Task Category

Arch Tests

Task Sub Category

  • gcc
  • binutils
  • gdb
  • intrinsics
  • Java
  • KVM
  • ld
  • llvm
  • Linux kernel
  • QEMU
  • Spike

Ratification Target

2021

Statement of Work (SOW)

SOW: link

SOW Signoffs: (delete those not needed)

  • Task group liaison sign-off date:
  • Development partner sign-off date:
  • ACT SIG sign-off date (if ACT work):

Waiver

  • Freeze
  • Ratification

Pull Request Details

ACT PR #1 (closed)
ACT and Coverpoints PR #2
ISAC PR (merged)

@jjscheel
Copy link
Contributor Author

ACT PR

@UmerShahidengr, what is the status here? It is still marked as being reviewed in your spreadsheet, but the PR seems to have bene closed and re-opened.

@jjscheel
Copy link
Contributor Author

@UmerShahidengr, would you kindly let me know what github id we have for Abdul as well? THANKS!

@UmerShahidengr
Copy link

Thats still in review status. There are conflict issue in the PR which was resolved by reverting a few commits and then re-opening the PR.

@jjscheel jjscheel assigned Abdulwadoodd and unassigned jjscheel Apr 13, 2023
@UmerShahidengr
Copy link

Update April 25th, 2023 => The PR is still in review. Due to Ramazan and Eid Holidays, no major work was done for this week, thus I am removing it from the agenda items.
Next week task => Work on a test for pseudo-misaligned memory access to check the boundary cases of PMP.

@jjscheel
Copy link
Contributor Author

Update from Allen:

  1. Got the next version of the trap handler working and tested (With help for 10xe folks) and merged.
    It is now possible to write tests of virtual memory, transition between protections mode easily, and write tests that can partition > permissions inside test code and data.
  2. continue to partition and Test Format Spec into ACT Developer Spec and ACT User Spec, and continue to get new chair up to speed
  3. no
  4. I don't have any dates....

@jjscheel
Copy link
Contributor Author

Oops, previous post was for wrong item. Pls ignore.

@jjscheel
Copy link
Contributor Author

@Abdulwadoodd, any update here? Thanks.

@UmerShahidengr
Copy link

Update ⇾ June 12th, 2023:
No update so far. We will come back to this project in the next week

@jjscheel
Copy link
Contributor Author

Ok, removing from Agenda for this week. Re-visit in 3 weeks.

@UmerShahidengr
Copy link

Update ⇾ July 11th, 2023
Not much work can be done here unless misaligned test cases are added. Coverpoints for PMP are getting developed but they are being tracked on different issue i.e, #13

@UmerShahidengr
Copy link

Update ⇾ August 15th, 2023
PMP coverpoints are ready and are available here for review.
Furthermore, misaligned access tests are still missing, which will be added in this quarter.

@UmerShahidengr
Copy link

Update ⇾ September 12th, 2023
No update on this.

@UmerShahidengr
Copy link

Update ⇾ September 26th, 2023
No update on this.

@UmerShahidengr
Copy link

Update ⇾ October 10th, 2023
No update on this.

@UmerShahidengr
Copy link

Update ⇾ October 24th, 2023
No update on this.

@UmerShahidengr
Copy link

Update ⇾ November 28th, 2023
PMP coverpoints have been added. Here is the link to the PR.

@UmerShahidengr
Copy link

Update ⇾ December 12th, 2023
The review process is going on smoothly.

@UmerShahidengr
Copy link

Update ⇾ January 30th, 2024
The review process is going on.

@UmerShahidengr
Copy link

Update ⇾ March 5th, 2024
@MuhammadHammad001 has added privilege coverpoint support in RISC-V ISAC (PR here), @allenjbaum has been working with @MuhammadHammad001 to write a translator for priv architecture which will help in writing priv arch coverpoints with better readability.
The coverpoint definitions are getting converted according to the new template, it will be completed in this quarter hopefully.

@UmerShahidengr
Copy link

Update ⇾ April 2nd, 2024
@MuhammadHammad001 has been working on PMP coverpoints, the PR will be completed before the next meeting

@jjscheel
Copy link
Contributor Author

@UmerShahidengr, how are the cover points coming along?

@UmerShahidengr
Copy link

@jjscheel coverpoints are completed. I will add the PR tonight

@jjscheel
Copy link
Contributor Author

I see old PR closed. Is this the new one: riscv-non-isa/riscv-arch-test #462?

@UmerShahidengr
Copy link

Yes. Thats the new one, and it is now complete with all tests and coverpoint definitions

@UmerShahidengr
Copy link

Update June 11th, 2024:
Coverpoint definitions and new template of writing coverpoints for Priv Architecture are still in review process, @allenjbaum has been reviewing this one and @MuhammadHammad001 has been working on it full time

@UmerShahidengr
Copy link

Update June 25th, 2024:
This task is still in review. @allenjbaum and @MuhammadHammad001 have been working on it.

@UmerShahidengr
Copy link

Update July 23rd, 2024:
This task is in review. @allenjbaum is spending some time reviewing it. Hopefully it will be completed soon

@UmerShahidengr
Copy link

Update August 6th, 2024:
The review process is complete, @allenjbaum has reviewed the PR, now it will be merged soon

@jjscheel
Copy link
Contributor Author

jjscheel commented Aug 6, 2024

Great news, @UmerShahidengr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: As-planned
Development

No branches or pull requests

3 participants