Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: spaceDapp to check for enabled space, channel before conducting entitlement checks #1168

Open
clemire opened this issue Sep 25, 2024 · 2 comments
Labels
area/sdk workitem Workitem that requires implementation

Comments

@clemire
Copy link
Contributor

clemire commented Sep 25, 2024

SpaceDapp currently does not check to see if spaces or channels are enabled before considered if a user is entitled for a space or channel action, and this puts it out of sync with the stream node's entitlement check logic. This should be fixed.

@clemire
Copy link
Contributor Author

clemire commented Sep 25, 2024

update: we don't really use disabled spaces or channels at this point, this is v low priority.

@sergekh2 sergekh2 added area/sdk workitem Workitem that requires implementation labels Sep 30, 2024
@texuf
Copy link
Contributor

texuf commented Oct 3, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sdk workitem Workitem that requires implementation
Projects
Status: In Progress
Development

No branches or pull requests

3 participants