Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Useless const spa? #13

Open
frederikhors opened this issue Oct 18, 2020 · 3 comments
Open

Useless const spa? #13

frederikhors opened this issue Oct 18, 2020 · 3 comments

Comments

@frederikhors
Copy link
Contributor

Now we have this, but where it's used?

const spa = false
@rixo
Copy link
Owner

rixo commented Oct 18, 2020

It was used to add the --single flag to sirve, in the custom server plugin that has changed during last merge.

You need that for non hashed-based client side routing. It's an issue that comes quite often with people that want to do SPAs. The point was to help with this situation.

We can probably remove this now. What do you think?

How is the SPA hard point addressed in the official template currently?

@frederikhors
Copy link
Contributor Author

Do you refer to this? sveltejs/template#116

I think we can enlight this in Readme and remove that const.

I'm using --single in serve function.

@rixo
Copy link
Owner

rixo commented Oct 21, 2020

Yes that's what I'm referring to. Apparently unsolved upstream... I guess we can just drop the const for now and follow suit if they take any decision 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants