Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do we need //@hmr:keep now? #19

Open
frederikhors opened this issue Nov 29, 2020 · 2 comments
Open

Do we need //@hmr:keep now? #19

frederikhors opened this issue Nov 29, 2020 · 2 comments

Comments

@frederikhors
Copy link
Contributor

frederikhors commented Nov 29, 2020 •
edited
Loading

Do we need //@hmr:keep now?
@rixo
Copy link
Owner

rixo commented Nov 30, 2020

Yes, we do.

Default behavior has been changed from preserving the value of all variables, which was understandably confusing people, to not preserving the state of any variable except those tagged with the magic comment, for the cases where you really want it (and then easily understand why its value is not reset).

@frederikhors
Copy link
Contributor Author

Maybe we should update docs? I don't know. If not you can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rixo @frederikhors