Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

after I update vscode-insiders error ocurried #317

Open
GeorgiNiagulov opened this issue Sep 6, 2024 · 20 comments · May be fixed by #318
Open

after I update vscode-insiders error ocurried #317

GeorgiNiagulov opened this issue Sep 6, 2024 · 20 comments · May be fixed by #318

Comments

@GeorgiNiagulov
Copy link

synthwaveError

@VanderSP
Copy link

YESSSSSSSSSSSSSSSS also just happened now... was 1.94 update.... how i will code now! i always needed to reenable synthwave, in admin mode... then reopen... etc... but was worth! :D

PLEASE WE WANT FIX!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

@vinayakkulkarni
Copy link

vinayakkulkarni commented Sep 15, 2024

024-09-16 02:28:08.674 [error] TypeError: Cannot read properties of undefined (reading 'filename')
    at /Users/vinayak/.vscode-insiders/extensions/robbowen.synthwave-vscode-0.1.15/src/extension.js:27:44

Seems the VSCode insiders update introduced a bug on this line –> https://github.com/robb0wen/synthwave-vscode/blob/master/src/extension.js#L27

After much more digging, found this – https://github.com/microsoft/vscode-docs/blob/vnext/release-notes/v1_93.md#impact-of-ecmascript-module-esm-loading-of-vs-code

@vinayakkulkarni
Copy link

Found a possible solution / hack:

update your local extension.js with this:

      const isWin = /^win/.test(process.platform);
      const appDir = `${path.dirname(vscode.env.appRoot)}/app/out`;
      const base = appDir + (isWin ? "\\vs\\code" : "/vs/code");
      const electronBase = isVSCodeBelowVersion("1.70.0")
        ? "electron-browser"
        : "electron-sandbox";
      const htmlFile =
        base +
        (isWin
          ? "\\" + electronBase + "\\workbench\\workbench.esm.html"
          : "/" + electronBase + "/workbench/workbench.esm.html");
      const templateFile =
        base +
        (isWin
          ? "\\" + electronBase + "\\workbench\\neondreams.js"
          : "/" + electronBase + "/workbench/neondreams.js");

Basically you have to patch these lines – https://github.com/robb0wen/synthwave-vscode/blob/master/src/extension.js#L26-L41

Might send a PR for the fix.

@vinayakkulkarni vinayakkulkarni linked a pull request Sep 15, 2024 that will close this issue
1 task
@VanderSP
Copy link

VanderSP commented Sep 15, 2024

Hey THANKS! Back working in NEON!!!!!!!!!

Also i would like to ask you all, you all use it like me?

i open vscode as admin... apply the synthwave command with ctrl shift p and selecting it

then restart.... then restart again without admin

then finally hitting to dont say alert anymore....

EVERYTIME THAT I HIT UPDATE ON INSIDERS LOL

@GeorgiNiagulov
Copy link
Author

Yes this fix it's working thanks :) I believe https://github.com/robb0wen will see and accept pull request!

@jd78
Copy link

jd78 commented Oct 3, 2024

I'm experiencing the same problem on MacOS, and the suggested solution isn't effective for this operating system. After making some adjustments, I got that VS Code needs to run with administrative privileges. And even doing so nothing happens.

@ikariiwarrior
Copy link

This is now an issue on public release of VSCode. Nice work, @vinayakkulkarni for patching in a fix. Hopefully it will be rolled into master and deployed soon. :)

@badrat8
Copy link

badrat8 commented Oct 3, 2024

@vinayakkulkarni thanks a lot, couldnt work without this theme :)

@AgGro00
Copy link

AgGro00 commented Oct 3, 2024

Same problem

@NathyVZM
Copy link

NathyVZM commented Oct 3, 2024

@vinayakkulkarni thank you so much for the patch 😭❤️ i can be happy again with the neon dreams. Hopefully they'll push this to master 🥹

@AgGro00
Copy link

AgGro00 commented Oct 3, 2024

Found a possible solution / hack:

update your local extension.js with this:

      const isWin = /^win/.test(process.platform);
      const appDir = `${path.dirname(vscode.env.appRoot)}/app/out`;
      const base = appDir + (isWin ? "\\vs\\code" : "/vs/code");
      const electronBase = isVSCodeBelowVersion("1.70.0")
        ? "electron-browser"
        : "electron-sandbox";
      const htmlFile =
        base +
        (isWin
          ? "\\" + electronBase + "\\workbench\\workbench.esm.html"
          : "/" + electronBase + "/workbench/workbench.esm.html");
      const templateFile =
        base +
        (isWin
          ? "\\" + electronBase + "\\workbench\\neondreams.js"
          : "/" + electronBase + "/workbench/neondreams.js");

Basically you have to patch these lines – https://github.com/robb0wen/synthwave-vscode/blob/master/src/extension.js#L26-L41

Might send a PR for the fix.

It worked for me to replace the current configuration with this

@vinayakkulkarni
Copy link

Lol, my VSCode updated to v1.95 & it stopped working again, seems VSCode reverted workbench.esm.html to workbench.html. Updated the PR 4a2935d (#318)

@barguti
Copy link

barguti commented Oct 8, 2024

Found a possible solution / hack:

update your local extension.js with this:

      const isWin = /^win/.test(process.platform);
      const appDir = `${path.dirname(vscode.env.appRoot)}/app/out`;
      const base = appDir + (isWin ? "\\vs\\code" : "/vs/code");
      const electronBase = isVSCodeBelowVersion("1.70.0")
        ? "electron-browser"
        : "electron-sandbox";
      const htmlFile =
        base +
        (isWin
          ? "\\" + electronBase + "\\workbench\\workbench.esm.html"
          : "/" + electronBase + "/workbench/workbench.esm.html");
      const templateFile =
        base +
        (isWin
          ? "\\" + electronBase + "\\workbench\\neondreams.js"
          : "/" + electronBase + "/workbench/neondreams.js");

Basically you have to patch these lines – https://github.com/robb0wen/synthwave-vscode/blob/master/src/extension.js#L26-L41

Might send a PR for the fix.

It works, thanks @AgGro00

@johnelliottwizio
Copy link

it worked thank you @AgGro00 , my brain can't work wit out GLOW

@harishhbaskar
Copy link

I am on fedora linux will this fix work on my system?

@puentebravo
Copy link

puentebravo commented Oct 12, 2024

Found a possible solution / hack:

update your local extension.js with this:

      const isWin = /^win/.test(process.platform);
      const appDir = `${path.dirname(vscode.env.appRoot)}/app/out`;
      const base = appDir + (isWin ? "\\vs\\code" : "/vs/code");
      const electronBase = isVSCodeBelowVersion("1.70.0")
        ? "electron-browser"
        : "electron-sandbox";
      const htmlFile =
        base +
        (isWin
          ? "\\" + electronBase + "\\workbench\\workbench.esm.html"
          : "/" + electronBase + "/workbench/workbench.esm.html");
      const templateFile =
        base +
        (isWin
          ? "\\" + electronBase + "\\workbench\\neondreams.js"
          : "/" + electronBase + "/workbench/neondreams.js");

Basically you have to patch these lines – https://github.com/robb0wen/synthwave-vscode/blob/master/src/extension.js#L26-L41

Might send a PR for the fix.

You're a Neon saint - thank you! Can confirm this works perfectly on Windows. I live for that glow, man.

@UR-Hiro
Copy link

UR-Hiro commented Oct 14, 2024

Can you teach me how to update it. I don't know how to do it. And I cannot live without the glow.
Thanks, in advance.

@koudy2
Copy link

koudy2 commented Oct 15, 2024

I am on fedora linux will this fix work on my system?

Yes it works. Running fedora as well

Can you teach me how to update it. I don't know how to do it. And I cannot live without the glow. Thanks, in advance.

What you see here (the piece of code pasted above in this issue) is the fix.

  1. Navigate to $USER/.vscode/extensions/robbowen.synthwave-.../src (note that ... before /src is placeholder for string with version) and there will be extension.js
  2. Make backup copy of this file so you have something to fall back to in case you need to start over
  3. Locate lines 26-41
  4. Paste the code from here to replace them and save the file

@larrydevofficial
Copy link

larrydevofficial commented Oct 15, 2024

Working on Mac with latest VSCode 1.94.2. After enabling neon dreams, you might have to go to

Preferences: Color Theme

scroll down and hover over SynthWave '84 then you should be able to see the lights when you select your actual preferred Color Theme

@alex1727tonato
Copy link

Estoy en Fedora Linux. ¿Esta solución funcionará en mi sistema?

Sí, funciona. También se ejecuta Fedora.

¿Puedes enseñarme cómo actualizarlo? No sé cómo hacerlo y no puedo vivir sin el brillo. Gracias de antemano.

Lo que ves aquí (el fragmento de código pegado arriba en este problema) es la solución.

  1. Vaya a $USER/.vscode/extensions/robbowen.synthwave-.../src(tenga en cuenta que ... antes de /src hay un marcador de posición para la cadena con la versión) y habrá extension.js
  2. Haz una copia de seguridad de este archivo para tener algo a lo que recurrir en caso de que necesites empezar de nuevo.
  3. Localiza las líneas 26-41
  4. Pegue el código desde aquí para reemplazarlos y guardar el archivo.

For Ubuntu, where is?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.