Allow to enable/disable pretty print via CLI

[robiningelbrecht]

Currently when adding the extension in the PHPUnit XML file, the output is always prettified. It should be possible to enable/disable this with an argument in the CLI command

Requested by @TomasVotruba in indentno/phpunit-pretty-print#47

@TomasVotruba suggestion on how you would approach this?

[TomasVotruba]

Hi,

thanks for creating the isuse :) 👍

I don't use PHPUnit internals much, so not sure this is possible.

In PHPUnit 9 there was a "printer" option: https://github.com/indentno/phpunit-pretty-print

vendor/bin/phpunit --printer 'Sempro\PHPUnitPrettyPrinter\PrettyPrinter' tests/

But I can't find it in PHPUnit 10 options:

vendor/bin/phpunit -h | grep "printer"
>

[robiningelbrecht]

@TomasVotruba there's indeed no printer option in PHPUnit 10 anymore, everything is managed through extensions. What I'd suggest to do is something like this:

<extensions>
    <bootstrap class="RobinIngelbrecht\PHPUnitPrettyPrint\PhpUnitExtension">
        <parameter name="enabled" value="true|false"/>
    </bootstrap>
</extensions>

or at runtime

> vendor/bin/phpunit -d --enable-pretty-print

The default value of this new option would always be "true". Your use case could then be solved by setting your XML to

<extensions>
    <bootstrap class="RobinIngelbrecht\PHPUnitPrettyPrint\PhpUnitExtension">
        <parameter name="enabled" value="false"/>
    </bootstrap>
</extensions>

and run

> vendor/bin/phpunit -d --enable-pretty-print

What do you think?

[TomasVotruba]

That seems great, I'd love to use this 👍

Does this work already?

[robiningelbrecht]

@TomasVotruba no, something I need to implement still. I'll try to finish this this week. Maybe tomorrow :)

[TomasVotruba]

@robiningelbrecht Awesome, thank you for helpling out 👍

[robiningelbrecht]

@TomasVotruba, see #2, what do you think?

[robiningelbrecht]

@TomasVotruba released a new version 1.2.2

[TomasVotruba]

Thank you 👏