Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests for driver using gRPC #9

Open
gavv opened this issue Oct 9, 2024 · 0 comments
Open

Add integration tests for driver using gRPC #9

gavv opened this issue Oct 9, 2024 · 0 comments
Labels
good first issue Good for newcomers help wanted Contributions are welcome tests Improvements or additions to tests

Comments

@gavv
Copy link
Member

gavv commented Oct 9, 2024

Implement a few simple tests for driver that connect to it via gRPC, add and remove devices, and observe results.

Related files:

  • rpc/driver_protocol.proto defines RPC interface
  • test - directory for tests (we use GoogleTest)
  • tool/connector.cpp - example of client code that connects to driver using gRPC

Example tests:

  • call ping(), call driver_info()
  • add device (add_device()), check that we can retrieve device info (get_device()) and it has correct parameters, check that it appeared in device list (get_all_devices())
  • remove device, check that it was removed from list and info can't be retrieved
  • call toggle/bind/connect, and check updated info

These tests will require driver to be loaded, so they should be run after executing make install and make kick. They should be excluded from make test by default and should invoked separately, e.g. using make driver_test.

We should run these tests on CI.

@gavv gavv added good first issue Good for newcomers help wanted Contributions are welcome tests Improvements or additions to tests labels Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Contributions are welcome tests Improvements or additions to tests
Projects
None yet
Development

No branches or pull requests

1 participant