Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question about cli #199

Open
jradom opened this issue Nov 5, 2020 · 14 comments
Open

question about cli #199

jradom opened this issue Nov 5, 2020 · 14 comments
Assignees
Labels
question Further information is requested

Comments

@jradom
Copy link

jradom commented Nov 5, 2020

Hi Roman,

I'm very happy with your tool but we are moving towards Javascript/Typescript. Is it possible for you to build a jar with parameters input? So, I'll be able to invoke it from Typescript? Please, let me know

Thanks

Jeff

@jradom jradom added the question Further information is requested label Nov 5, 2020
@romankh3
Copy link
Owner

romankh3 commented Nov 5, 2020

Hi, @jradom.
I think we can do it as a new repository, but I don't have enough time

@romankh3 romankh3 closed this as completed Dec 7, 2020
@jradom
Copy link
Author

jradom commented Dec 7, 2020

Hi Roman,

Does it mean that you don't have time and desire adding CLI capabilities? Pleas, let me know one way or another

Thanks

Jeff

@romankh3
Copy link
Owner

romankh3 commented Dec 7, 2020

Hi Jeff,
Yes, I don't have time for it.

From my perspective, it's easy to do, so you can do it.

Thanks,
Roman.

@jradom
Copy link
Author

jradom commented Dec 7, 2020 via email

@romankh3
Copy link
Owner

romankh3 commented Dec 7, 2020

@jradom, You know. Project is not working without consumers.
Provide here functionality, which you’re using in library and I will create it.

@romankh3 romankh3 reopened this Dec 7, 2020
@jradom
Copy link
Author

jradom commented Dec 8, 2020

FYI, I really like and so is my management but there is a competition even in open source. And the reason I can't easily do it because I'm not a real expert in such kind of tools.

Cheers (Spasibo)

Jeff

@jradom
Copy link
Author

jradom commented Dec 14, 2020

Just a friendly reminder. Did you have any chance to work on my request because I'll need to use some sort of Visual testing n my upcoming Typescript project?

Thanks in advance

Jeff

@romankh3
Copy link
Owner

As I understood, you decided to stop using library at all, didn’t you?
If not, provide options which you’re using in comparing. After that I will provide program.

@jradom
Copy link
Author

jradom commented Dec 15, 2020

Hi Roman,

It's kinda funny and might be lost in translation or miscommunication. This is what I wrote recently "FYI, I really like and so is my management but there is competition even in open source. And the reason I can't easily do it because I'm not a real expert in such kind of tools." Again I do like your tools with all features and accuracy of it, etc. And I have/had a plan to call it from my Typescript code once you'll expose options to a jar file CLI. I'd prefer to have all or most options to be exposed to CLI but make them optional with some defaults. And a simple sample code maybe in Typescript (optional). Actually, we use the Cypress UI testing tool. Again your stuff is great and I had found something similar I still will prefer to use yours. I also hope I'll be able to reuse my previous test configurations in the new project and Typescript. It'll be great if you can do it in a timely fashion. I hope I've clarified my goals.

Thanks

Jeff

@jradom
Copy link
Author

jradom commented Dec 15, 2020

Oh, I think you were confused that I said if you not gonna do it I MIGHT need to switch to some other tool

@romankh3
Copy link
Owner

Ok, I think I can do it.

@jradom
Copy link
Author

jradom commented Dec 21, 2020 via email

@scp-WFZ
Copy link

scp-WFZ commented May 24, 2022

@romankh3 Hi, I'd like to work on the issue.

@romankh3
Copy link
Owner

@scp-WFZ hi, I had CLI in library in a past and removed it.

As you can see our dialoge above, it should be done in separated repository just because I want to save image-comparison as a library, not a product.

Feel free to do it in this repo: https://github.com/romankh3/image-comparison-cli

scp-WFZ added a commit to scp-WFZ/image-comparison that referenced this issue May 29, 2022
//CS304 Issue link: romankh3#199
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants