Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the using of logger for python class Cache and ApproximateTimeSynchronizer #8

Open
gaoethan opened this issue Sep 12, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@gaoethan
Copy link
Contributor

This is the follow-up to the future optimization of the logger using in #7 for the following comment from @tfoote , now it's using exclusive named logger instead of the root logger within the initial porting.

However we've been looking at this elsewhere and for useful logging we will likely need to pass in the logger objects so that they can be remapped and otherwise grouped appropriately. So adding the logger to the init signature wouldn't be unreasonable. We can ticket that as a follow up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants