Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor internal data structures in graph_cache.hpp #132

Open
Yadunund opened this issue Mar 21, 2024 · 0 comments
Open

Refactor internal data structures in graph_cache.hpp #132

Yadunund opened this issue Mar 21, 2024 · 0 comments
Labels
backlog Long-term improvement or addition

Comments

@Yadunund
Copy link
Member

Follow up to #103 (comment)

We should

  • Convert GraphNode to a class
  • Nest GraphNode inside GraphCache and move the TopicXMap definitions to GraphCache
  • Consider nesting TopicData within GraphNode
  • Move all TopicData and GraphNode member variables into private scope and add getters/setters to access them.
@Yadunund Yadunund mentioned this issue Mar 21, 2024
Merged
2 tasks
@clalancette clalancette added the backlog Long-term improvement or addition label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog Long-term improvement or addition
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@clalancette @Yadunund