Skip to content
This repository has been archived by the owner on May 19, 2023. It is now read-only.

Add factory methods #42

Open
2 of 4 tasks
ilanolkies opened this issue Dec 21, 2020 · 2 comments
Open
2 of 4 tasks

Add factory methods #42

ilanolkies opened this issue Dec 21, 2020 · 2 comments
Labels
refactor Refactor

Comments

@ilanolkies
Copy link
Contributor

ilanolkies commented Dec 21, 2020 •
edited
Loading

The method should automatically setup sign, decrypt and getEncryptionPublicKey.

In addition, public key returned by getEncryptionPublicKey should be memoized. See:

Originally posted by @ilanolkies in #41 (comment)

  • AsymmetricEncryptionManager
  • SignerEncryptionManager
  • AuthManager
  • DataVaultWebClient
@ilanolkies
Copy link
Contributor Author

ilanolkies commented Jul 22, 2021 •
edited
Loading

This now exists for AsymmetricEncryptionManager and SignerEncryptionManager. We need to add it to AuthManager. Ref: #73

Additional, we can add factory method for DataVaultWebClient with this logic https://github.com/rsksmart/rif-identity-manager/blob/develop/src/app/state/operations/datavault.ts#L15-L35

@ilanolkies ilanolkies changed the title Add fromProvider factory method Add factory methods Jul 22, 2021
@ilanolkies ilanolkies added the refactor Refactor label Jul 22, 2021
@ilanolkies
Copy link
Contributor Author

Duplicated code here too:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
refactor Refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ilanolkies