From 31447a749bacbc993c04571b095687ad9484e38c Mon Sep 17 00:00:00 2001 From: pshu Date: Fri, 21 Aug 2026 15:46:06 +0800 Subject: [PATCH] fix(tanstack-start): pin solid-js to 1.x for devtools peer @tanstack/devtools declares `solid-js: >=1.9.7` as a peer dependency, so a full re-resolution dedupes it onto the workspace's solid-js@2.0.0-rc.0 (introduced by #495 for the Rsbuild Solid example) instead of its own `solid-js: ^1.9.9` dependency. Solid 2 dropped `onMount`/`batch`/`on`/ `getListener` and the `./web` subpath export, breaking the build. Declaring solid-js explicitly pins this example's subtree back to 1.x without touching the Solid example. --- pnpm-lock.yaml | 3 +++ rsbuild/tanstack-start/package.json | 1 + 2 files changed, 4 insertions(+) diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 7372b1f5..ac814c49 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -825,6 +825,9 @@ importers: '@types/react-dom': specifier: ^19.2.3 version: 19.2.3(@types/react@19.2.15) + solid-js: + specifier: ^1.9.9 + version: 1.9.13 typescript: specifier: ^6.0.3 version: 6.0.3 diff --git a/rsbuild/tanstack-start/package.json b/rsbuild/tanstack-start/package.json index 04d0b1d7..ff35a918 100644 --- a/rsbuild/tanstack-start/package.json +++ b/rsbuild/tanstack-start/package.json @@ -29,6 +29,7 @@ "@types/node": "^24.12.4", "@types/react": "^19.2.15", "@types/react-dom": "^19.2.3", + "solid-js": "^1.9.9", "typescript": "^6.0.3" } }