Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 'latest minor version' of d3 #54

Open
npjc opened this issue Feb 16, 2019 · 0 comments
Open

Add support for 'latest minor version' of d3 #54

npjc opened this issue Feb 16, 2019 · 0 comments

Comments

@npjc
Copy link

npjc commented Feb 16, 2019

If I understand correctly r2d3 D3 support up to 5.0.0 but suggests that the latest minor version is supported (see screenshot below). How would one go about supporting up to the actual latest minor release (5.9.1 at the time of this writing, see d3/releases)?

This would make r2d3 better as it could take advantage of the latest improvements. As an example, the very useful+convenient d3-selection.join is >= 5.8.0.

I would be happy to help but I'm not sure how to implement this as I am not yet very familiar with the package. From my experiments It seems that simply adding/changing the minified source in www/inst/d3 doesn't cause an error but does cause the default d3 script to plot an empty svg.

screen shot 2019-02-16 at 10 07 55 am

javierluraschi added a commit that referenced this issue Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant