Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use variant if only saving a single screenshot #183

Open
gadenbuie opened this issue May 22, 2023 · 0 comments
Open

Don't use variant if only saving a single screenshot #183

gadenbuie opened this issue May 22, 2023 · 0 comments

Comments

@gadenbuie
Copy link
Member

In several cases, in particular with focused tests that don't primarily rely on snapshots, we only take screenshots on a single OS and R version, e.g. MacOS + r-latest.

In these cases, we should set variant = NULL in the app options.

We should also have shared code that returns TRUE for mac-latest + r-latest, to facilitate deciding whether or not to take a screenshot.

As a side benefit, this also helps with the initial set up of a test; the first screenshots can be created locally regardless of OS and R version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant