Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When used inside Emacs with Reline, input is echoed #644

Closed
dgutov opened this issue Mar 14, 2024 · 4 comments
Closed

When used inside Emacs with Reline, input is echoed #644

dgutov opened this issue Mar 14, 2024 · 4 comments

Comments

@dgutov
Copy link

dgutov commented Mar 14, 2024

Description

This issue is about using Pry as a Ruby REPL inside Emacs.

The effect looks very much like #616:

[1] pry(main)> [1] pry(main)> 2
[1] pry(main)> 2[1] pry(main)> 2=> 2
[2] pry(main)> [2] pry(main)> 3
[2] pry(main)> 3[2] pry(main)> 3=> 3
[3] pry(main)> [3] pry(main)> 

But there doesn't seem to be any interest in having this solved inside Reline (i.e. providing a "simple" io driver).

What are your expected behavior and actual behavior of your environment?

The expected behavior is that the input is not copied or otherwise reproduced in the output.

This problem come up more often now than Ruby 3.3 defaults to Reline.

Terminal Emulator

Comint inside Emacs.

IRB has a workaround: when launched with --nosingleline --nomultiline, it switches to a different I/O implementation, which it calls StdioInputMethod.

Should Pry carry its own solution like that as well? The hackish patch below seems to do the trick. It can be a configuration option, a separate wrapper class, etc.

@@ -179,7 +179,10 @@
           end
         end
 
-        if readline_available?
+        if ENV['TERM'] == 'dumb'
+          STDOUT.print(current_prompt)
+          STDIN.gets
+        elsif readline_available?
           set_readline_output
           input_readline(current_prompt, false) # false since we'll add it manually
         elsif coolline_available?

Downstream report: dgutov/robe#147 (comment)

@dgutov dgutov changed the title When used inside Emacs with Reline (e.g. Ruby 3.3 by default), input is echoed When used inside Emacs with Reline, input is echoed Mar 14, 2024
@dgutov
Copy link
Author

dgutov commented Mar 14, 2024

Sorry, wrong repo.

@dgutov dgutov closed this as not planned Won't fix, can't repro, duplicate, stale Mar 14, 2024
@freesteph
Copy link

@dgutov can you point the new one? I encounter these problems in Emacs and am also confused between irb, debug, reline, etc, etc, etc. Happy to follow your investigation.

@dgutov
Copy link
Author

dgutov commented Mar 21, 2024

@freesteph See pry/pry#2303.

Irb has its own way of disabling Reline, so see the above and the linked PR for a similar solution for Pry.

Not sure about debug, haven't tested that yet.

Perhaps Reline itself should have a "dumb" backend with automatic switchover, or a fix for this some other way, but I don't understand the code enough to suggest anything in particular.

@dgutov
Copy link
Author

dgutov commented Sep 24, 2024

Update for those coming from search results:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants