Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize action lists #13

Open
Shockbound opened this issue Mar 5, 2019 · 0 comments
Open

Organize action lists #13

Shockbound opened this issue Mar 5, 2019 · 0 comments

Comments

@Shockbound
Copy link

Should probably read similar to the subaction lists, by splitting actions into groups with relevant headers (i.e. Specials, Other, Overrides, Generic).

Specials should contain the main four actions for Neutral-B (0x112), Side-B (0x113), Up-B (0x114), and Down-B (0x115).

Other should contain the unnamed actions with IDs higher than the four main special actions. All of these actions are full of character specific coding that is accessed very frequently. Specials are often not contained in just one action, and tend to split into different actions when certain conditions are met. It would be best to put these extra actions in a different category from the main four special actions, because some movesets may redirect to this action from different places and will behave differently depending on what the previous action was. Some actions, such as Mewtwo's hover and Peach's float, aren't even tied to a special at all.

Overrides contain character specific action coding that replaces generic action coding. Not all characters utilize this, but it's important for the ones that do. A different issue has already been opened for this, so I won't go into too much detail about this here.

Generic actions include coding that is supplied directly from Fighter.pac, and contains universal coding that gets applied to all characters (unless it is replaced by an override). Since this coding is the same for every character and encompasses such a large amount of actions, it would be best if these were all at the bottom of the list since they won't be accessed by users as often as the other actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant