Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor foundry_get_model and print_failure_info #1955

Open
palinatolmach opened this issue Jul 12, 2023 · 0 comments
Open

Refactor foundry_get_model and print_failure_info #1955

palinatolmach opened this issue Jul 12, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@palinatolmach
Copy link
Contributor

palinatolmach commented Jul 12, 2023

As suggested by @tothtamas28, the function foundry_get_model(...) introduced in #1946 should produce a data structure (maybe FoundryModel | None). Function print_model can be a method on this class (without the "Failed to ..." branch). Function print_failure_info then can be redefined as

def print_failure_info(kprint: KPrint, proof: Proof, *, model: FoundryModel | None = None) -> list[str]:
    ...

In addition, as suggested by @nwatson22, print_failure_info in KEVM should be further refactored to use the print_failure_info function that was added to pyk to separate the printing from the RPC calls here: runtimeverification/pyk@6c28b66.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant