Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up unnecessary bitcasts #1104

Open
dwightguth opened this issue Jul 9, 2024 · 0 comments
Open

Clean up unnecessary bitcasts #1104

dwightguth opened this issue Jul 9, 2024 · 0 comments
Labels
code generation Refactoring Fix or improvement on LLVM Backend

Comments

@dwightguth
Copy link
Collaborator

One thing I noticed while working on #1103 was that there's a lot of places in the code generator where we bitcast one pointer type to another pointer type. This is pretty much redundant now; all pointer types are now the same ptr type, ptr. The bitcasts don't really hurt anything in production because unless you are running on -O0, which we generally don't, the optimization pipeline will remove them. But it's probably still worth cleaning them up wherever possible at some point in order to reduce code complexity.

@dwightguth dwightguth added code generation Refactoring Fix or improvement on LLVM Backend labels Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code generation Refactoring Fix or improvement on LLVM Backend
Projects
None yet
Development

No branches or pull requests

1 participant