Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add search bar in Main Container #1354

Closed
4 tasks done
AlfiyaSiddique opened this issue Jul 19, 2023 · 9 comments
Closed
4 tasks done

[Feature] Add search bar in Main Container #1354

AlfiyaSiddique opened this issue Jul 19, 2023 · 9 comments

Comments

@AlfiyaSiddique
Copy link
Contributor

Description

There is no search bar in the main container, so if there are too many resources and tools present in a category as in the case of the Images, Design, and Fonts category of the frontend, then it might get difficult to find a particular resource.

So to make the finding process easier we should add a search bar in the main container that should search through the resources present in the main container at the time of searching.

Screenshots

No response

Checklist

  • I have checked the existing issues
  • I have read the Contributing Guidelines
  • I am willing to work on this issue (optional)
  • I am a GSSoC'23 contributor
@github-actions
Copy link

To reduce notifications, issues are locked. Your issue will be unlocked when we add the label, 🚀 ready.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2023
Repository owner unlocked this conversation Jul 27, 2023
@rupali-codes
Copy link
Owner

@AlfiyaSiddique thanks, i would like to know how are you going to approach this?

@AlfiyaSiddique
Copy link
Contributor Author

Sure @rupali-codes , Here's how I'm gonna achieve it!

First I'll add a search input in the main section that could be in the GeneralLayout component.
Then I'll implement the logic to pass the search input value to the CardList component
Then using that value I'll filter the card's prop which will render the actual card in the end.

Hence only those tool cards will appear on the screen whose name matches the character entered in the search bar.

Please provide your suggestions if you have any.

@rupali-codes
Copy link
Owner

@AlfiyaSiddique thanks.

@rupali-codes
Copy link
Owner

@k-deepak04 @CBID2 and @Anmol-Baranwal what do you guys about this?

@k-deepak04
Copy link
Contributor

yeah, we can go for this

@Anmol-Baranwal
Copy link
Collaborator

Yeah, the idea is good from what I can understand.

However, I would like to see the final implementation before suggesting anything.

So, we can definitely go for this.

@rupali-codes
Copy link
Owner

Yeah, the idea is good from what I can understand.

However, I would like to see the final implementation before suggesting anything.

So, we can definitely go for this.

in the current sidebar, we are searching globally, do we still need it?

@rupali-codes
Copy link
Owner

closing the issue bcz' of inactivity :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants