Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] improvements in light and dark theme #2247

Closed
3 tasks done
Anmol-Baranwal opened this issue Jan 31, 2024 · 8 comments · Fixed by #2344
Closed
3 tasks done

[Feature] improvements in light and dark theme #2247

Anmol-Baranwal opened this issue Jan 31, 2024 · 8 comments · Fixed by #2344
Assignees
Labels
goal: new-feature New feature or request level2 Modifying an existing feature priority: high Making completely new feature

Comments

@Anmol-Baranwal
Copy link
Collaborator

Anmol-Baranwal commented Jan 31, 2024

Description

@rupali-codes
I'm creating this issue, where we can further improve the light theme.

Feel free to update this issue, or the points.


  1. A bit of a border and small shadow box.
White (to improve) Dark (inspiration)
image image
  1. Hover color changes on selected links.

image

  1. A bit of a border and small shadow box.
White (to improve) Dark (inspiration)
image image
  1. Improve breadcrumbs.
White (to improve) Dark (inspiration)
image image
  1. A border on the searchbar
White (to improve) Dark (inspiration)
image image
  1. A border and shadow box.

image


@aftabrehan @CBID2
Feel free to suggest whatever you think!

Screenshots

Next time :)

Checklist

  • I have checked the existing issues
  • I have read the Contributing Guidelines
  • I am willing to work on this issue (optional)
@Anmol-Baranwal Anmol-Baranwal added discussion For taking issues into discussion board priority: high Making completely new feature labels Jan 31, 2024
Copy link

Hello Anmol-Baranwal!
Thank you for raising this issue! 😊 Your contribution is valuable to us! 😊

Please make sure to follow our Contributing Guidelines. 💪🏻

Please only work on an issue if you're assigned; otherwise, the PR will be automatically closed.
Our review team will carefully assess the issue and reach out to you soon! 😇
We appreciate your patience!

Copy link

To reduce notifications, issues are locked. Your issue will be unlocked when we add the label, 🚀 ready.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2024
@CBID2 CBID2 removed the 🔒 locked label Feb 1, 2024
@CBID2
Copy link
Collaborator

CBID2 commented Feb 1, 2024

I think a black border would make it more bearable to view @Anmol-Baranwal

@Anmol-Baranwal
Copy link
Collaborator Author

I think a black border would make it more bearable to view @Anmol-Baranwal

Yeah, I second that :)

@CBID2
Copy link
Collaborator

CBID2 commented Feb 1, 2024

I think a black border would make it more bearable to view @Anmol-Baranwal

Yeah, I second that :)

What do you think @aftabrehan?

@aftabrehan
Copy link
Collaborator

Yeah, the border would improve visibility.

@CBID2
Copy link
Collaborator

CBID2 commented Feb 3, 2024

Great! :) I'll give this a shot @Anmol-Baranwal! :)

@CBID2 CBID2 added goal: new-feature New feature or request level2 Modifying an existing feature and removed discussion For taking issues into discussion board labels Feb 3, 2024
@CBID2 CBID2 self-assigned this Feb 3, 2024
@Anmol-Baranwal
Copy link
Collaborator Author

Great! :) I'll give this a shot @Anmol-Baranwal! :)

Sure. Go ahead :)

@github-actions github-actions bot closed this as completed Mar 6, 2024
@CBID2 CBID2 reopened this Mar 6, 2024
@github-actions github-actions bot closed this as completed Apr 7, 2024
@CBID2 CBID2 reopened this Apr 7, 2024
@Anmol-Baranwal Anmol-Baranwal changed the title [Feature] improvements in light theme of LinksHub [Feature] improvements in light and dark theme Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
goal: new-feature New feature or request level2 Modifying an existing feature priority: high Making completely new feature
Projects
None yet
3 participants