Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI [BUG] <Query Parameters Displayed in Breadcrumbs for Specific Search Results> #2504

Open
3 tasks done
gauravxroy opened this issue Sep 26, 2024 · 9 comments
Open
3 tasks done
Assignees
Labels
bug Something isn't working priority: medium Modifying an existing feature

Comments

@gauravxroy
Copy link

gauravxroy commented Sep 26, 2024

Description

When users perform a search using the search bar in the application, the breadcrumb navigation reflects the API route or endpoint rather than the intended UI structure. Instead of displaying a user-friendly path breadcrumbs like > Home > Search > Ethers, the breadcrumbs show a format such as " Home > Search {query=endpoint} > Search Result". This inclusion of the API route or endpoint (enclosed in {}) in the breadcrumb navigation is not desirable and affects the user experience.

Steps to Reproduce: -
-Navigate to the search bar in the application.
-Enter a search query(like Ethers, Truffle) and execute the search(The issue is producing when we hit enter key in order to hit the search queries).
-Observe the breadcrumb navigation in the UI.

Suggested Methods/ways to resolve the Issues:
1>UI State Management:
Ensure proper state updates for breadcrumbs, isolating them from API responses.
Implement a dedicated breadcrumb component to manage display logic.
2>Routing Configuration:
Review route definitions to prevent API parameters from appearing in breadcrumbs.
Use custom route handling to separate UI routes from API calls.
3>API Response Handling:
Keep API logic separate from UI logic to avoid affecting breadcrumb structure.
Transform API responses to exclude unnecessary parameters.

I want to address the issue with breadcrumb navigation to ensure it displays user-friendly paths instead of API endpoints.

Screenshots

Current Breadcrumbs Behaviours :
Screenshot 2024-09-26 102701
Screenshot 2024-09-26 102853

Required Breadcrumbs Behaviour:
Screenshot 2024-09-26 104714

Any additional information?

No response

What browser are you seeing the problem on?

Firefox, Chrome, Microsoft Edge

Checklist

  • I have checked the existing issues
  • I have read the Contributing Guidelines
  • I am willing to work on this issue (optional)
@gauravxroy gauravxroy added bug Something isn't working priority: medium Modifying an existing feature labels Sep 26, 2024
Copy link

Hello gauravxroy!
Thank you for raising this issue! 😊 Your contribution is valuable to us! 😊

Please make sure to follow our Contributing Guidelines. 💪🏻

Please only work on an issue if you're assigned; otherwise, the PR will be automatically closed.
Our review team will carefully assess the issue and reach out to you soon! 😇
We appreciate your patience!

@heysolomon
Copy link
Contributor

@rupali-codes I would like to work on this

@rupali-codes
Copy link
Owner

@gauravxroy do you want to work on this?

@gauravxroy
Copy link
Author

gauravxroy commented Sep 30, 2024

@gauravxroy do you want to work on this?

@rupali-codes Absolutely, I'm excited to work on this issue.

@rupali-codes
Copy link
Owner

@gauravxroy do you want to work on this?

@rupali-codes Absolutely, I'm excited to work on this issue.

Alright, assigning to you.

And, @heysolomon, please have a look on other opened issues, since @gauravxroy wants to work on it so we'll assign the issue to them as per our Contributing guidelines.

@gauravxroy
Copy link
Author

@gauravxroy do you want to work on this?

@rupali-codes Absolutely, I'm excited to work on this issue.

Alright, assigning to you.

And, @heysolomon, please have a look on other opened issues, since @gauravxroy wants to work on it so we'll assign the issue to them as per our Contributing guidelines.

@rupali-codes Thank you, Rupali. I will work on resolving this issue and close this as soon as possible.

@gauravxroy
Copy link
Author

gauravxroy commented Oct 21, 2024

@rupali-codes Hey, Rupali Sorry for delay , due to some unexpected health issues i was not able to work on this issue but , now I will try to resolve this issue within a week.

@rupali-codes
Copy link
Owner

Hi @gauravxroy, is there any update on this?

@gauravxroy
Copy link
Author

@rupali-codes yes majority of work has been done , after analysing and improving written codes I will make a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: medium Modifying an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants