-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tables not rendering after upgrade to 2.0.0 #394
Comments
No, you're using the right options (nit: you can omit |
Strange, I can't reproduce (ignore the funky import, it's my local clone of v2):
|
It's |
It is highly recommended to fix it |
My workaround for this is to |
I have a PR for this, #428, but it's insufficient. It doesn't break any existing tests, and addresses some of the cases with Windows-style newlines, but not all. When I try to exercise it well by replacing all newlines in all test cases before running them, I still get a ton of failures, so a complete fix is not ready yet. Meanwhile, @kirides's workaround seems like a quick solution for those of you who need to live with this. |
This bug also hit me. @kirides workaround fixed it. You should really make a proper fix. On mac localhost. |
Yesterday I updated the #428 PR with what I hope to be a complete fix: it passes all the reference tests with EOLs replaced. Please give it a spin with your input. |
428PR still does not work for my input. Here is the input hex: 4e616d65202020207c204167650d0a2d2d2d2d2d2d2d2d7c2d2d2d2d2d2d0d0a426f6220202020207c2032370d0a416c6963652020207c203233 |
Sorry last comment from work (picoeric) BTW, I am calling it thus: post.Body is of type string, and contains the hex (as string) of last comment |
I have a fix for tables (including this particular test case), but in doing so I enabled double-testing for all the remaining tests with Windows-style newlines and that uncovered a bunch of failures that I haven't encountered yet. It will take some more time to squish them all. PR #428 is going to be large... BTW, @exyzzy, a lovely solution to use |
Thanks @rtfb, I'll pick this up when it hits master. |
I upgraded my project from blackfriday 1.5.0 to 2.0.0, but when I run it on the following markdown, the table fails to render now:
This is how I am calling blackfriday in 2.0.0:
Am I using the wrong options?
The text was updated successfully, but these errors were encountered: