Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing safety section #101

Closed
andreeaflorescu opened this issue Jun 24, 2020 · 0 comments · Fixed by #108
Closed

Missing safety section #101

andreeaflorescu opened this issue Jun 24, 2020 · 0 comments · Fixed by #108
Assignees
@lauralt

Comments

@andreeaflorescu
Copy link
Member

Unsafe functions need to have in the documentation a # Safety section.

We missed this as we weren't running clippy properly. Related to rust-vmm/rust-vmm-ci#21
lauralt added a commit to lauralt/kvm-ioctls that referenced this issue Jul 23, 2020
@lauralt
fix clippy warnings
9612c12 
A more recent clippy version requires the public
unsafe functions to have a #Safety section in their
documentation.
Fixes: rust-vmm#101.

Signed-off-by: Laura Loghin <lauralg@amazon.com>
lauralt added a commit to lauralt/kvm-ioctls that referenced this issue Jul 23, 2020
@lauralt
fix clippy warnings
a1d754c 
A more recent clippy version requires the public
unsafe functions to have a #Safety section in their
documentation.
Fixes: rust-vmm#101.

Signed-off-by: Laura Loghin <lauralg@amazon.com>
@lauralt lauralt mentioned this issue Jul 23, 2020
Merged
andreeaflorescu pushed a commit that referenced this issue Jul 24, 2020
@lauralt @andreeaflorescu
fix clippy warnings
c346b17 
A more recent clippy version requires the public
unsafe functions to have a #Safety section in their
documentation.
Fixes: #101.

Signed-off-by: Laura Loghin <lauralg@amazon.com>
baciumar pushed a commit to baciumar/kvm-ioctls that referenced this issue Nov 9, 2020
@lauralt @baciumar
fix clippy warnings
f413aac 
A more recent clippy version requires the public
unsafe functions to have a #Safety section in their
documentation.
Fixes: rust-vmm#101.

Signed-off-by: Laura Loghin <lauralg@amazon.com>
Signed-off-by: Marius-Cristian Baciu <baciumar@amazon.com>
baciumar pushed a commit to baciumar/kvm-ioctls that referenced this issue Nov 9, 2020
@lauralt @baciumar
fix clippy warnings
6881fbc 
A more recent clippy version requires the public
unsafe functions to have a #Safety section in their
documentation.
Fixes: rust-vmm#101.

Signed-off-by: Laura Loghin <lauralg@amazon.com>
Signed-off-by: Marius-Cristian Baciu <baciumar@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lauralt lauralt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix clippy warnings lauralt/kvm-ioctls
2 participants
@andreeaflorescu @lauralt