Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing safety section #101

Closed
andreeaflorescu opened this issue Jun 24, 2020 · 0 comments · Fixed by #108
Closed

Missing safety section #101

andreeaflorescu opened this issue Jun 24, 2020 · 0 comments · Fixed by #108
Assignees

Comments

@andreeaflorescu
Copy link
Member

Unsafe functions need to have in the documentation a # Safety section.

We missed this as we weren't running clippy properly. Related to rust-vmm/rust-vmm-ci#21

lauralt added a commit to lauralt/kvm-ioctls that referenced this issue Jul 23, 2020
A more recent clippy version requires the public
unsafe functions to have a #Safety section in their
documentation.
Fixes: rust-vmm#101.

Signed-off-by: Laura Loghin <lauralg@amazon.com>
lauralt added a commit to lauralt/kvm-ioctls that referenced this issue Jul 23, 2020
A more recent clippy version requires the public
unsafe functions to have a #Safety section in their
documentation.
Fixes: rust-vmm#101.

Signed-off-by: Laura Loghin <lauralg@amazon.com>
andreeaflorescu pushed a commit that referenced this issue Jul 24, 2020
A more recent clippy version requires the public
unsafe functions to have a #Safety section in their
documentation.
Fixes: #101.

Signed-off-by: Laura Loghin <lauralg@amazon.com>
baciumar pushed a commit to baciumar/kvm-ioctls that referenced this issue Nov 9, 2020
A more recent clippy version requires the public
unsafe functions to have a #Safety section in their
documentation.
Fixes: rust-vmm#101.

Signed-off-by: Laura Loghin <lauralg@amazon.com>
Signed-off-by: Marius-Cristian Baciu <baciumar@amazon.com>
baciumar pushed a commit to baciumar/kvm-ioctls that referenced this issue Nov 9, 2020
A more recent clippy version requires the public
unsafe functions to have a #Safety section in their
documentation.
Fixes: rust-vmm#101.

Signed-off-by: Laura Loghin <lauralg@amazon.com>
Signed-off-by: Marius-Cristian Baciu <baciumar@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants