Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire plugin #195

Open
5 tasks
slawekjaranowski opened this issue Aug 14, 2024 · 4 comments
Open
5 tasks

Retire plugin #195

slawekjaranowski opened this issue Aug 14, 2024 · 4 comments

Comments

@slawekjaranowski
Copy link
Member

slawekjaranowski commented Aug 14, 2024

As Apache Maven GPG Plugin supports now:

  • support BC BouncyCastle java library signer -gpg binary is not necessary
  • support environment variables
  • works with Maven 4

https://maven.apache.org/plugins/maven-gpg-plugin/examples/deploy-signed-artifacts.html#sign-using-bc-signer

I'm going to retire this plugin

Task to do:

  • prepare migration example to maven-gpg-plugin
  • add info about retired in docs
  • deprecate Mojo with info about retiring
  • release latest version
  • make repository read-only
@slawekjaranowski slawekjaranowski pinned this issue Aug 14, 2024
@mkarg
Copy link
Contributor

mkarg commented Aug 15, 2024

Farewell, sign plugin!

OTOH I thought your intention for starting this plugin was to get rid of a the need for a locally installed GPG. Does that mean that Maven GPG Plugin works without local GPG now? 🤔

@slawekjaranowski
Copy link
Member Author

slawekjaranowski commented Aug 15, 2024

Farewell, sign plugin!

OTOH I thought your intention for starting this plugin was to get rid of a the need for a locally installed GPG. Does that mean that Maven GPG Plugin works without local GPG now? 🤔

Exactly it was an intention - signing without additional binary and better support builds on CI system

Now we have the same in gpg-plugin thanks to BC - Bouncy Castle Java library additional binary is not necessary.
Also we have support for configuration keys by environments variables.

I will prepare some manual about migration.

So maintain next plugin with the same feature is not justified.

@mkarg
Copy link
Contributor

mkarg commented Aug 16, 2024

So in fact it is not GPG plugin anymore, but BC plugin. ;-)

@slawekjaranowski
Copy link
Member Author

So in fact it is not GPG plugin anymore, but BC plugin. ;-)

No. There is an option: https://maven.apache.org/plugins/maven-gpg-plugin/sign-mojo.html#signer

The name of the Signer implementation to use. Accepted values are "gpg" (the default, uses GnuPG executable) and "bc" (uses Bouncy Castle pure Java signer).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants