Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 5 incompatibility #8

Open
rousisk opened this issue Aug 21, 2018 · 3 comments
Open

Rails 5 incompatibility #8

rousisk opened this issue Aug 21, 2018 · 3 comments

Comments

@rousisk
Copy link

rousisk commented Aug 21, 2018

Hi,

We just upgraded to Rails 5 and our integration broke (while using 0.4.0).

After bumping to the latest version of the gem (0.4.1), we now get this error:

5: from /home/rousis/.rbenv/versions/2.5.1/lib/ruby/gems/2.5.0/gems/activeresource-5.0.0/lib/active_resource/base.rb:935:in `find'
4: from /home/rousis/.rbenv/versions/2.5.1/lib/ruby/gems/2.5.0/gems/activeresource-5.0.0/lib/active_resource/base.rb:1027:in `find_every'
3: from /home/rousis/.rbenv/versions/2.5.1/lib/ruby/gems/2.5.0/gems/sk_sdk-0.4.1/lib/sk_sdk/ar_patches/ar4/base.rb:28:in `instantiate_collection'
2: from /home/rousis/.rbenv/versions/2.5.1/lib/ruby/gems/2.5.0/gems/sk_sdk-0.4.1/lib/sk_sdk/ar_patches/ar4/base.rb:28:in `new'
1: from /home/rousis/.rbenv/versions/2.5.1/lib/ruby/gems/2.5.0/gems/activeresource-5.0.0/lib/active_resource/collection.rb:57:in `initialize'
ArgumentError (wrong number of arguments (given 2, expected 0..1))

Have you successfully tried with a Rails 5 app and it worked for you?

@schorsch
Copy link
Member

please check if this fixes your issues. At least it does in my tests. I will bump a new version than.
Thanks for the report!

@siebertm
Copy link

On it, give me 10minutes!

@siebertm
Copy link

Awesome @schorsch it works 👍

Can we maybe have a quick chat about the support experience we had (after the version bump)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants