Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Captions display over top of progress bar #658

Open
1 task
elynema opened this issue Oct 8, 2024 · 1 comment
Open
1 task

[BUG] Captions display over top of progress bar #658

elynema opened this issue Oct 8, 2024 · 1 comment
Assignees
Labels
bug 🐛 Something isn't working

Comments

@elynema
Copy link

elynema commented Oct 8, 2024

Describe the bug
With the new multi-line progress bar + video.js widget display, multi-line captions are overlapping the progress bar. The captions should not overlap the progress bar.

To Reproduce
Steps to reproduce the behavior:

  1. Go to a record in avalon-dev with captions: https://avalon-dev.dlib.indiana.edu/media_objects/37720c78r/section/cv43nw85w
  2. Begin playback with captions turned on
  3. You will see the captions overlap the progress bar once there is a multi-line caption.

Expected behavior
The captions should display above the progress bar. Note: LinkedIn Learning uses video.js as well, and they have the captions move up (when the progress bar / widgets are visible) and down (when the progress bar and widgets disappear). This would be a cool solution.

This has not been tested on mobile devices, so not sure if it will work differently there.

Screenshots
Current display in Avalon:

Screen.Recording.2024-10-08.at.3.50.10.PM.mov

LinkedIn example:

Screen.Recording.2024-10-08.at.3.47.15.PM.mov

Desktop (please complete the following information):

  • OS: MacOS
  • Browser: Chrome
  • Version: 129.0.6668.70

QA

  • Test caption display and progress bar on Chrome desktop, Safari on iPhone/iPad, and Chrome on Android
@elynema elynema added the bug 🐛 Something isn't working label Oct 8, 2024
@joncameron
Copy link
Contributor

joncameron commented Oct 11, 2024

Could be a CSS change; VideoJS also has options that could be used for this purpose. JS-based approach could be better across platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants