Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read module dependencies from meta.yml #1

Closed
jvfe opened this issue Jun 21, 2024 · 1 comment
Closed

Read module dependencies from meta.yml #1

jvfe opened this issue Jun 21, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@jvfe
Copy link
Collaborator

jvfe commented Jun 21, 2024

Current Scenario

  • Currently, get_components_to_install is the function used to download and update both subworkflows and modules.
    image

  • It gets called as part of the init method of the ComponentInstall class, which is used for both modules and subworkflows.
    f

  • The function itself only takes subworkflow_dir as an argument, and attemps to find the respective modules using relative paths.

Proposed solution

  • Change the function to read from a subworkflow's meta.yml, which will contain extra keys when necessary, to specify if the module should be pulled from a different remote and not the one the subworkflow is hosted in.
  • This idea was originally suggested here
@jvfe jvfe self-assigned this Jun 21, 2024
@jvfe jvfe added the enhancement New feature or request label Jun 21, 2024
@jvfe jvfe pinned this issue Jun 23, 2024
@jvfe
Copy link
Collaborator Author

jvfe commented Jul 29, 2024

Done in #8

@jvfe jvfe closed this as completed Jul 29, 2024
@jvfe jvfe unpinned this issue Jul 29, 2024
@jvfe jvfe pinned this issue Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

1 participant