Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eppy-core -- initial conda-forge support #421

Open
airallergy opened this issue May 26, 2023 · 3 comments
Open

eppy-core -- initial conda-forge support #421

airallergy opened this issue May 26, 2023 · 3 comments

Comments

@airallergy
Copy link
Contributor

This issue follows up discussion in #265 for clarity, regarding eppy's conda support.

  • Scope: conda-forge -- a community-maintained conda channel hosting a variety of packages, as opposed to the default channel maintained by Anaconda.
  • Approach: a eppy-core package that contains all eppy scripts with a subset of eppy's current dependencies hosted on pypi. The subset are minimal dependencies needed for eppy's core function of model editing, which are:
    - python >=3.8  # 3.7 will be obsolete next month (Jun 2023)
    - munch >=2.0.2  # same as on pypi
    - decorator >=4.0.10  # same as on pypi
    - numpy  # tinynumpy is required on pypi, but not available on conda-forge 
             # there might be an issue with older versions, but kept unconstraint for now

A few notes:

  • A conda-forge recipe usually contains tests for imports and pypi dependency matching. The latter is not included as there are clearly conflicts, which is why we have espy-core in the first place. If one day we decide to make some pypi dependencies optional, we can certainly introduce the latter then. The import test is included:
    - eppy
    - eppy.modeleditor
  • @santoshphilip, would you like to be listed as a maintainer? I have not done so, as I gather that you don't (actively) use conda, and there can be spam emails as warned by the conda-forge team (hence they require consent by comment). That being said, I am not seeing too much of maintaining work as eppy is pure python as I mentioned in the other issue, do let me know if you would like to be listed :)

At the time of creating this issue, I have submitted the recipe PR (conda-forge/staged-recipes#22920) and all tests have passed. I will mark it ready for review now.

@airallergy
Copy link
Contributor Author

Good news! As of now, eppy-core has been made available on conda-forge, one can install it via

conda install -c conda-forge eppy-core

For reference, the feedstock repo is https://github.com/conda-forge/eppy-core-feedstock

Everything looks fine on conda's server and my local environment, we need to wait for the next eppy release to see if it can be picked up automatically.

@santoshphilip, we may want to document this somewhere. Besides, do you have anything else in mind to be done for us to finish this bit up?

We might consider printing some useful info regarding imports for situations where users install via eppy-core and try to use some functions that require non-core dependencies, but that can be tracked in a new issue.

@santoshphilip
Copy link
Owner

It should have some mention on the install page of eppy documentation - saying that a conda install can be done, and how to do it.

The eppy documentation or README should have a link to https://github.com/conda-forge/eppy-core-feedstock

Leave this issue open until I bend my mind around things that need to be done. I am caught up in another project now. Will get to this by the weekend.

@airallergy
Copy link
Contributor Author

Justing thinking that, it might be a good idea to create a 'metaissue' to contain a list of TODOs for enhancing the eppy release procedure. This issue can be cross referenced as the first in that TODO list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants