Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runIDFs() method suggestion #443

Open
rodrigokl opened this issue Jul 15, 2024 · 3 comments
Open

runIDFs() method suggestion #443

rodrigokl opened this issue Jul 15, 2024 · 3 comments

Comments

@rodrigokl
Copy link

Hey guys,

Before submitting to a pull request, I would like to suggest a small update to the runIDFs and prepare_run methods, both of which create/read the 'multi_runs' folder at os.mkdir('multi_runs'), but when I try to run multiple parallel instances (for example, in a 20 thread processor, 4 runs with 5 simulations each), we replace the simulations as they run, losing the outputs at the end.

To fix this, my suggestion is to add some output_dir to 'multi_runs' like this:

def runIDFs(jobs, processors=1, debug=False, output_dir='multi_runs')
 
 def prepare_run(run_id, run_data, output_dir='multi_runs')
@santoshphilip
Copy link
Owner

@rodrigokl , Just acknowledging that I have seen the issue.
From your description, it sounds like a nasty bug.

I may need your help in recreating is issue on my end.

I am caught up in some other work right now. Will check in with you in a couple of days.

@rodrigokl
Copy link
Author

Hello @santoshphilip, here is a suggestion for the 'RunIDFs' and 'prepare_run' methods.
run_functions.zip

@santoshphilip
Copy link
Owner

@rodrigokl sorry for the delay. Somehow I did not get a notification email on your post. I start to look into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants